You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2018/07/25 19:47:00 UTC

[jira] [Commented] (WICKET-6574) JQueryResourceReference#get() (still) return V1

    [ https://issues.apache.org/jira/browse/WICKET-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556187#comment-16556187 ] 

Martin Grigorov commented on WICKET-6574:
-----------------------------------------

Here is how this issue has been found: https://github.com/adessoAG/wicked-charts/issues/153
I don't remember the discussion about using V1 in #get() for compatibility but I think Wicket should use the same version as default, i.e. V2.

> JQueryResourceReference#get() (still) return V1
> -----------------------------------------------
>
>                 Key: WICKET-6574
>                 URL: https://issues.apache.org/jira/browse/WICKET-6574
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.0.0
>            Reporter: Sebastien Briquet
>            Priority: Major
>
> JQueryResourceReference#get() returns V1 (jquery-1.12.4) and is marked as deprecated
> It is still called by JQueryPluginResourceReference, in the case the application does not exists.
> On another side, we have WicketAjaxJQueryResourceReference, which does explicitly returns V2 in the case the application does not exists.
> IIRC V1 was returned by #get() to keep the compatibility. Maybe it's time to remove #get() and make JQueryPluginResourceReference use V2?
> WDYT ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)