[jira] Commented: (WICKET-499) Investigate whether we can use component meta data for the storage of feedback messages

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491513 ] 

Igor Vaynberg commented on WICKET-499:
--------------------------------------

* no central storage place, making it harder to track.

i disagree this is a con. component and session messages are different, and as you have learned yourself it is a huge pain to keep them together. two+ weeks after you made the change we are still finding cases where it doesnt work.


* probably less efficient in both storage and processing.
but proper cleanup is trivial. component.ondetach() { setmetadata(feedbackkey, null); }

> Investigate whether we can use component meta data for the storage of feedback messages
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-499
>                 URL: https://issues.apache.org/jira/browse/WICKET-499
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Eelco Hillenius
>             Fix For: 1.3
>
>
> Investigate this. See also http://www.nabble.com/Re%3A-svn-commit%3A-r530991---in--incubator-wicket-trunk-jdk-1.4-wicket-src-main-java-org-apache-wicket%3A-Session.java-feedback-FeedbackMessages.java-p10119808.html
> Advantages of doing this:
> * it is a one-one mapping of the concept that you set a message on a component;
> * you'll never have to worry about cleanup up; just clean up rendered messages, and leave unrendered for whenever they are request or until the component is garbage collected.
> Disadvantages:
> * no central storage place, making it harder to track.
> * probably less efficient in both storage and processing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.