You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/27 13:53:38 UTC

[GitHub] [spark] tgravescs commented on pull request #28323: [SPARK-31551][CORE] Fix createSparkUser lost user's non-Hadoop credentials

tgravescs commented on pull request #28323:
URL: https://github.com/apache/spark/pull/28323#issuecomment-620001049


   it's been a long time since I looked at this so I will have to go refresh my memory but I don't think using getUserName works in all cases.
   
   What kind of testing have you done on this?  Note the question is How was this patch tested, so can you please give more details on  unit tests and manual testing done.  In this case we need to have tested in various secure environments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org