[GitHub] [airflow] ashb commented on a change in pull request #8572: Improve template capabilities of EMR job and step operators

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #8572:
URL: https://github.com/apache/airflow/pull/8572#discussion_r416151252



##########
File path: airflow/providers/amazon/aws/operators/emr_add_steps.py
##########
@@ -38,13 +38,14 @@ class EmrAddStepsOperator(BaseOperator):
     :type cluster_states: list
     :param aws_conn_id: aws connection to uses
     :type aws_conn_id: str
-    :param steps: boto3 style steps to be added to the jobflow. (templated)
-    :type steps: list
+    :param steps: boto3 style steps or reference to a steps file (must be '.json' or '.jinja2') to
+        be added to the jobflow. (templated)
+    :type steps: list|str
     :param do_xcom_push: if True, job_flow_id is pushed to XCom with key job_flow_id.
     :type do_xcom_push: bool
     """
     template_fields = ['job_flow_id', 'job_flow_name', 'cluster_states', 'steps']
-    template_ext = ()
+    template_ext = ('.json', '.jinja2')

Review comment:
       Nothing else uses `.jinja2` in Airflow, so I think we shouldn't create new pattern for just this operator.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org