You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Colafornia (via GitHub)" <gi...@apache.org> on 2026/09/02 10:16:16 UTC
Re: [PR] fix(runtime): preserve durable RuntimeEvent order [maka]
Colafornia commented on code in PR #4445:
URL: https://github.com/apache/maka/pull/4445#discussion_r3913052599
##########
packages/runtime/src/runtime-read-model.ts:
##########
@@ -250,6 +268,24 @@ export class RuntimeReadModel {
a.event.id.localeCompare(b.event.id),
);
+ const nextFallbackEventByRun = new Map<number, number>();
+ for (let index = 0; index < ordered.length; index += 1) {
+ const item = ordered[index]!;
+ if (item.ordinal !== undefined) continue;
+ const next = nextFallbackEventByRun.get(item.runIndex) ?? 0;
+ ordered[index] = fallbackEventsByRun.get(item.runIndex)![next]!;
+ nextFallbackEventByRun.set(item.runIndex, next + 1);
+ }
+
+ const durableEvents = ordered
Review Comment:
Accepted in 4f85c3def. Production presentation now intentionally follows immutable session append order. MemoryAgentRunStore records the same global ordinals, and the overlapping-run test now exercises and names durable session chronology. The PR and issue descriptions state the behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org