You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/20 11:14:49 UTC

[GitHub] [kylin] codecov-io commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement

codecov-io commented on issue #1165: KYLIN-4354 Prune segment not using given filter when using jdbc preparestatement
URL: https://github.com/apache/kylin/pull/1165#issuecomment-601647642
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=h1) Report
   > Merging [#1165](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/734a997a05bee7b722010b177ec0cce8494bcd1d&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1165/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1165      +/-   ##
   ============================================
   - Coverage     25.05%   25.05%   -0.01%     
   + Complexity     6249     6247       -2     
   ============================================
     Files          1446     1446              
     Lines         88309    88310       +1     
     Branches      12358    12358              
   ============================================
   - Hits          22128    22126       -2     
   + Misses        64009    64008       -1     
   - Partials       2172     2176       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/cube/common/SegmentPruner.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9TZWdtZW50UHJ1bmVyLmphdmE=) | `56.92% <50.00%> (-5.58%)` | `25.00 <2.00> (ø)` | |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.60% <0.00%> (-0.61%)` | `7.00% <0.00%> (ø%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0.00%> (+2.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1165/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `55.68% <0.00%> (+3.40%)` | `8.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=footer). Last update [734a997...2a98e23](https://codecov.io/gh/apache/kylin/pull/1165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services