You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Vishal K <vi...@gmail.com> on 2010/07/29 22:48:22 UTC
Applying ZooKeeper patch
Hi,
What would be the right way to apply a zookeeper patch. For instance, if I
am using zookeeper-3-3.0 and I would like to apply a patch for ZOOKEEPER-790
to this version.
However, I presume that the patch that I have is generate from the trunk. Is
there a way I can get a patch specific to zookeeper-3-3.0?
Thanks.
-Vishal
Re: Applying ZooKeeper patch
Posted by Vishal K <vi...@gmail.com>.
Hi Patrick,
Will it be fair to ask the person who submits the patch to also submit a
patch for the version that you would want the patch to apply to? We can
certainly patch ourself. However, I am trying to understand what to expect
for support of older releases. Thanks.
-Vishal
On Mon, Aug 2, 2010 at 1:18 PM, Patrick Hunt <ph...@apache.org> wrote:
> The process I use is to d/l an official release (the one I need to provide
> a patch for), apply the patch and rebuild ("ant tar" is what we use for
> official releases). I typically try to keep the change delta small, document
> the baseline and patches applied, and encourage users to upgrade to an
> official version including the required fixes asap.
>
> Patrick
>
>
> On 07/29/2010 05:44 PM, Vishal K wrote:
>
>> Hi Patrick, Mahadev,
>>
>> We would like to apply critical patches asap. For example, this bug was
>> preventing a failed node to rejoin the cluster. In such cases, it won't be
>> possible to wait for the next version. What process do you suggest to be
>> follow in such a case? I am not restricting the discussion to this
>> particular bug (say I was using 3.2.2 or older version).
>>
>> Thanks.
>> -Vishal
>>
>> On Thu, Jul 29, 2010 at 6:12 PM, Patrick Hunt<ph...@apache.org> wrote:
>>
>> To be clear we are shooting for a release candidate next week, it will
>>> take
>>> a few days after that to go through the process before an official
>>> release
>>> is available.
>>>
>>> Patrick
>>>
>>>
>>> On 07/29/2010 02:22 PM, Mahadev Konar wrote:
>>>
>>> HI Vishal,
>>>> There is patch available for 3.3 branch which I think should apply.
>>>>
>>>>
>>>>
>>>> https://issues.apache.org/jira/secure/attachment/12450761/ZOOKEEPER-790-3.3
>>>> .
>>>> v2.patch
>>>>
>>>> On the other hand its not a good idea to have run your own patched
>>>> version
>>>> of ZooKeeper in production. 3.3.2 should be out by next week, you might
>>>> want
>>>> to wait for that and then use it.
>>>>
>>>> Thanks
>>>> mahadev
>>>>
>>>>
>>>> On 7/29/10 1:48 PM, "Vishal K"<vi...@gmail.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>>>
>>>>> What would be the right way to apply a zookeeper patch. For instance,
>>>>> if
>>>>> I
>>>>> am using zookeeper-3-3.0 and I would like to apply a patch for
>>>>> ZOOKEEPER-790
>>>>> to this version.
>>>>> However, I presume that the patch that I have is generate from the
>>>>> trunk.
>>>>> Is
>>>>> there a way I can get a patch specific to zookeeper-3-3.0?
>>>>>
>>>>> Thanks.
>>>>> -Vishal
>>>>>
>>>>>
>>>>
>>>>
>>
Re: Applying ZooKeeper patch
Posted by Patrick Hunt <ph...@apache.org>.
The process I use is to d/l an official release (the one I need to
provide a patch for), apply the patch and rebuild ("ant tar" is what we
use for official releases). I typically try to keep the change delta
small, document the baseline and patches applied, and encourage users to
upgrade to an official version including the required fixes asap.
Patrick
On 07/29/2010 05:44 PM, Vishal K wrote:
> Hi Patrick, Mahadev,
>
> We would like to apply critical patches asap. For example, this bug was
> preventing a failed node to rejoin the cluster. In such cases, it won't be
> possible to wait for the next version. What process do you suggest to be
> follow in such a case? I am not restricting the discussion to this
> particular bug (say I was using 3.2.2 or older version).
>
> Thanks.
> -Vishal
>
> On Thu, Jul 29, 2010 at 6:12 PM, Patrick Hunt<ph...@apache.org> wrote:
>
>> To be clear we are shooting for a release candidate next week, it will take
>> a few days after that to go through the process before an official release
>> is available.
>>
>> Patrick
>>
>>
>> On 07/29/2010 02:22 PM, Mahadev Konar wrote:
>>
>>> HI Vishal,
>>> There is patch available for 3.3 branch which I think should apply.
>>>
>>>
>>> https://issues.apache.org/jira/secure/attachment/12450761/ZOOKEEPER-790-3.3
>>> .
>>> v2.patch
>>>
>>> On the other hand its not a good idea to have run your own patched version
>>> of ZooKeeper in production. 3.3.2 should be out by next week, you might
>>> want
>>> to wait for that and then use it.
>>>
>>> Thanks
>>> mahadev
>>>
>>>
>>> On 7/29/10 1:48 PM, "Vishal K"<vi...@gmail.com> wrote:
>>>
>>> Hi,
>>>>
>>>> What would be the right way to apply a zookeeper patch. For instance, if
>>>> I
>>>> am using zookeeper-3-3.0 and I would like to apply a patch for
>>>> ZOOKEEPER-790
>>>> to this version.
>>>> However, I presume that the patch that I have is generate from the trunk.
>>>> Is
>>>> there a way I can get a patch specific to zookeeper-3-3.0?
>>>>
>>>> Thanks.
>>>> -Vishal
>>>>
>>>
>>>
>
Re: Applying ZooKeeper patch
Posted by Vishal K <vi...@gmail.com>.
Hi Patrick, Mahadev,
We would like to apply critical patches asap. For example, this bug was
preventing a failed node to rejoin the cluster. In such cases, it won't be
possible to wait for the next version. What process do you suggest to be
follow in such a case? I am not restricting the discussion to this
particular bug (say I was using 3.2.2 or older version).
Thanks.
-Vishal
On Thu, Jul 29, 2010 at 6:12 PM, Patrick Hunt <ph...@apache.org> wrote:
> To be clear we are shooting for a release candidate next week, it will take
> a few days after that to go through the process before an official release
> is available.
>
> Patrick
>
>
> On 07/29/2010 02:22 PM, Mahadev Konar wrote:
>
>> HI Vishal,
>> There is patch available for 3.3 branch which I think should apply.
>>
>>
>> https://issues.apache.org/jira/secure/attachment/12450761/ZOOKEEPER-790-3.3
>> .
>> v2.patch
>>
>> On the other hand its not a good idea to have run your own patched version
>> of ZooKeeper in production. 3.3.2 should be out by next week, you might
>> want
>> to wait for that and then use it.
>>
>> Thanks
>> mahadev
>>
>>
>> On 7/29/10 1:48 PM, "Vishal K"<vi...@gmail.com> wrote:
>>
>> Hi,
>>>
>>> What would be the right way to apply a zookeeper patch. For instance, if
>>> I
>>> am using zookeeper-3-3.0 and I would like to apply a patch for
>>> ZOOKEEPER-790
>>> to this version.
>>> However, I presume that the patch that I have is generate from the trunk.
>>> Is
>>> there a way I can get a patch specific to zookeeper-3-3.0?
>>>
>>> Thanks.
>>> -Vishal
>>>
>>
>>
Re: Applying ZooKeeper patch
Posted by Patrick Hunt <ph...@apache.org>.
To be clear we are shooting for a release candidate next week, it will
take a few days after that to go through the process before an official
release is available.
Patrick
On 07/29/2010 02:22 PM, Mahadev Konar wrote:
> HI Vishal,
> There is patch available for 3.3 branch which I think should apply.
>
> https://issues.apache.org/jira/secure/attachment/12450761/ZOOKEEPER-790-3.3.
> v2.patch
>
> On the other hand its not a good idea to have run your own patched version
> of ZooKeeper in production. 3.3.2 should be out by next week, you might want
> to wait for that and then use it.
>
> Thanks
> mahadev
>
>
> On 7/29/10 1:48 PM, "Vishal K"<vi...@gmail.com> wrote:
>
>> Hi,
>>
>> What would be the right way to apply a zookeeper patch. For instance, if I
>> am using zookeeper-3-3.0 and I would like to apply a patch for ZOOKEEPER-790
>> to this version.
>> However, I presume that the patch that I have is generate from the trunk. Is
>> there a way I can get a patch specific to zookeeper-3-3.0?
>>
>> Thanks.
>> -Vishal
>
Re: Applying ZooKeeper patch
Posted by Mahadev Konar <ma...@yahoo-inc.com>.
HI Vishal,
There is patch available for 3.3 branch which I think should apply.
https://issues.apache.org/jira/secure/attachment/12450761/ZOOKEEPER-790-3.3.
v2.patch
On the other hand its not a good idea to have run your own patched version
of ZooKeeper in production. 3.3.2 should be out by next week, you might want
to wait for that and then use it.
Thanks
mahadev
On 7/29/10 1:48 PM, "Vishal K" <vi...@gmail.com> wrote:
> Hi,
>
> What would be the right way to apply a zookeeper patch. For instance, if I
> am using zookeeper-3-3.0 and I would like to apply a patch for ZOOKEEPER-790
> to this version.
> However, I presume that the patch that I have is generate from the trunk. Is
> there a way I can get a patch specific to zookeeper-3-3.0?
>
> Thanks.
> -Vishal