You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/05 16:09:34 UTC

[GitHub] [spark] Shockang edited a comment on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

Shockang edited a comment on pull request #33101:
URL: https://github.com/apache/spark/pull/33101#issuecomment-874215443


   > Looks fine. The tests may be overkill but OK :)
   > Are there any other instance of .mkdirs() out there that should use the utility method, while we're here?
   
   Thank you for your attention  (｡･∀･)ﾉﾞ  In the Spark source code, in addition to the Utils class, there are two user-facing pieces of code and more than 30 test cases using mkdirs. Do you mean I need to replace all these places?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org