You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ol...@apache.org on 2008/09/06 01:07:20 UTC
svn commit: r692574 - in /continuum/trunk:
continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
continuum-model/src/main/mdo/continuum.xml
Author: olamy
Date: Fri Sep 5 16:07:20 2008
New Revision: 692574
URL: http://svn.apache.org/viewvc?rev=692574&view=rev
Log:
add some FIXME concerning CONTINUUM-1871
Modified:
continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
continuum/trunk/continuum-model/src/main/mdo/continuum.xml
Modified: continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java?rev=692574&r1=692573&r2=692574&view=diff
==============================================================================
--- continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java (original)
+++ continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java Fri Sep 5 16:07:20 2008
@@ -350,6 +350,10 @@
context.setOldBuildResult( oldBuildResult );
+ // FIXME CONTINUUM-1871 if continuum is killed the oldBuildResult will have a endTime 0
+ // and all ScmResult will be in memory and the contains method use toString from ChangeSet
+ // which do a lot String concat
+
if ( oldBuildResult != null )
{
context.setOldScmResult( getOldScmResult( projectId, oldBuildResult.getEndTime() ) );
Modified: continuum/trunk/continuum-model/src/main/mdo/continuum.xml
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-model/src/main/mdo/continuum.xml?rev=692574&r1=692573&r2=692574&view=diff
==============================================================================
--- continuum/trunk/continuum-model/src/main/mdo/continuum.xml (original)
+++ continuum/trunk/continuum-model/src/main/mdo/continuum.xml Fri Sep 5 16:07:20 2008
@@ -764,6 +764,7 @@
/**
* @return Returns string representation of the changeset
*/
+ // FIXME CONTINUUM-1871 use at least a StringBuilder here
public String toString()
{
String result = author + "\n" + date + "\n";