You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/14 21:00:33 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
junichi11 opened a new pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676
https://issues.apache.org/jira/browse/NETBEANS-4606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761616584
@junichi11 How are the stubs generated?
I noticed that stubs contain old parameter names.
PHP 8.0 changed names of parameters because they become part of the API by implementing named parameters RFC.
In PHP 7.4 `ini_set()` had parameters `$varname` and `$newvalue`, in PHP 8.0 parameters were renamed to `$option` and `$value`.
* PHP documentation: https://www.php.net/manual/en/function.ini-set.php
* PHP tasks: https://github.com/php/php-tasks/issues/16 and https://github.com/php/php-tasks/issues/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761640398
I'll just regenerate it with the latest manual again. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761750541
@junichi11 @KacerCZ
Let's resolve the comments and merge this PR, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761750415
@junichi11
Nothing to thank for. However, it was MUCH bigger project than I expected :sweat_smile:
@KacerCZ
It used to be from the documentation sources, for years. But the original code was really messy and difficult to maintain, moreover it was not easy to follow all the _magic_ which is done when PHP manual is generated. Therefore I decided to generate the PHP sigfiles from the HTML manual. I have it as a private repo on Bitbucket, let me know if you would like to have access there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-762465808
@KacerCZ Thank you for your verification!
@junichi11 Thank you for your work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-760476482
@tmysik Of course, thanks to you we can update this :) Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ edited a comment on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
KacerCZ edited a comment on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761616584
@junichi11 @tmysik How are the stubs generated?
I noticed that stubs contain old parameter names.
PHP 8.0 changed names of parameters because they become part of the API by implementing named parameters RFC.
In PHP 7.4 `ini_set()` had parameters `$varname` and `$newvalue`, in PHP 8.0 parameters were renamed to `$option` and `$value`.
* PHP documentation: https://www.php.net/manual/en/function.ini-set.php
* PHP tasks: https://github.com/php/php-tasks/issues/16 and https://github.com/php/php-tasks/issues/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761810730
@KacerCZ
Simple - because I don't want to. Details offline, if you are interested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-761769565
@tmysik Is there any reason why the tool can't be part of https://github.com/apache/netbeans-tools repository?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2676: [NETBEANS-4606] Regenerate signature files for PHP 8.0
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2676:
URL: https://github.com/apache/netbeans/pull/2676#issuecomment-762276190
Regenerated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists