You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:50:58 UTC
[GitHub] [flink] BenoitHanotte opened a new pull request #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
BenoitHanotte opened a new pull request #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854
## What is the purpose of the change
The RelNode's digest is used by the Calcite HepPlanner to avoid adding duplicate vertices to the graph. If an equivalent vertex was already present in the graph, then that vertex is used in place of the newly generated one. This means that the digest needs to contain all the information
necessary to identifying a vertex and distinguishing it from similar (but not equivalent) vertices.
In the case of the `WindowAggregation` nodes, the window specs are currently not in the digest, meaning that **two aggregations with the same signatures and expressions but different windows are considered equivalent by the planner, which is not correct and will lead to an invalid Physical Plan**.
This commit fixes this issue and adds a test ensuring that the window specs are in the digest, as well as similar aggregations on two different windows will not be considered equivalent.
Only the old planner is subject to the issue, the Blink planner correctly uses the window specs in the nodes' digests, allowing Blink to correctly differentiate between the nodes.
More info and an example of an invalid plan are avalaible at https://issues.apache.org/jira/browse/FLINK-15577
## Brief change log
Added window specs to the following RelNodes:
- LogicalWindowAggregate
- FlinkLogicalWindowAggregate
- LogicalWindowTableAggregate
- FlinkLogicalWindowTableAggregate
Added unit tests to the legacy planner and to the blink planner to prevent future regressions.
## Verifying this change
This change added tests and can be verified as follows:
- Added unit tests for the old planner to ensure window specs are in digest and that similar aggregations with different windows are not considered equivalent in the physical plan.
- Added unit tests for the blink planner to ensure no such regression can be introduced in the future.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144333023) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574184703
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8a356409214adf359c470c223bdfced819f7256a (Tue Jan 14 13:54:11 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144333023) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-576137954
LGTM, merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:MANUAL TriggerID:574277331
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:MANUAL TriggerID:574277331
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144333023) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144333023) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung closed pull request #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
KurtYoung closed pull request #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-575042514
LGTM, +1 to merge, thanks for the fix @BenoitHanotte.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] BenoitHanotte commented on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
BenoitHanotte commented on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574277331
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:MANUAL TriggerID:574277331
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144333023) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10854:
[FLINK-15577][table-planner] Fix similar aggregations with different
windows being considered the same
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10854: [FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same
URL: https://github.com/apache/flink/pull/10854#issuecomment-574189442
<!--
Meta data
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:PUSH TriggerID:8a356409214adf359c470c223bdfced819f7256a
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144333023 TriggerType:MANUAL TriggerID:574277331
Hash:8a356409214adf359c470c223bdfced819f7256a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335 TriggerType:MANUAL TriggerID:574277331
-->
## CI report:
* 8a356409214adf359c470c223bdfced819f7256a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144333023) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4335)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services