You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/01/17 08:39:00 UTC

[GitHub] [cassandra] bereng commented on pull request #1380: CASSANDRA-10537: CONTAINS and CONTAINS KEY support for Lightweight Transactions

bereng commented on pull request #1380:
URL: https://github.com/apache/cassandra/pull/1380#issuecomment-1014266010


   Hi,
   
   good job this looks very promising imo. I would also add tests in `ColumnConditionTest` and check other test classes that might apply.
   
   I would also add tests for corner cases like empty collections and such similar scenarios.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org