You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2019/06/20 15:48:46 UTC
[kudu] 03/03: [tablet_copy_client-test] fix compiler warning
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch branch-1.10.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 8c149902f4b226170ed78aef35de15b2d5696ca3
Author: Alexey Serbin <as...@cloudera.com>
AuthorDate: Tue Jun 18 16:41:23 2019 -0700
[tablet_copy_client-test] fix compiler warning
Fixed compilation warning in TabletCopyClientTest:
src/kudu/tserver/tablet_copy_client-test.cc:149:16: \
warning: 'GenerateTestData' overrides a member function but \
is not marked 'override' [-Winconsistent-missing-override]
virtual void GenerateTestData() {
^
src/kudu/tserver/tablet_copy-test-base.h:113:16: \
note: overridden virtual function is here
virtual void GenerateTestData() {
^
1 warning generated.
This patch does not contain any functional modifications.
Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Reviewed-on: http://gerrit.cloudera.org:8080/13674
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit d0db4c4cd36c1388e36576742cc7fe8c3adfcb77)
Reviewed-on: http://gerrit.cloudera.org:8080/13688
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/tserver/tablet_copy_client-test.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/tserver/tablet_copy_client-test.cc b/src/kudu/tserver/tablet_copy_client-test.cc
index 5dd9f4e..c24adb6 100644
--- a/src/kudu/tserver/tablet_copy_client-test.cc
+++ b/src/kudu/tserver/tablet_copy_client-test.cc
@@ -146,7 +146,7 @@ class TabletCopyClientTest : public TabletCopyTest {
Status CompareFileContents(const string& path1, const string& path2);
// Injection of 'supports_live_row_count' modifiers through polymorphic characteristic.
- virtual void GenerateTestData() {
+ void GenerateTestData() override {
Random rand(SeedRandom());
NO_FATALS(tablet_replica_->tablet_metadata()->
set_supports_live_row_count_for_tests(rand.Next() % 2));