You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/08/29 20:04:49 UTC
[GitHub] [ignite] mrk-andreev opened a new pull request #8196: IGNITE-13392: fix Incorrect Vector::kNorm evaluation for odd powers
mrk-andreev opened a new pull request #8196:
URL: https://github.com/apache/ignite/pull/8196
Current implementation of `Vector::kNorm` is incorrect.
Current formula is (`org.apache.ignite.ml.math.primitives.vector.AbstractVector:882`):
```
(\sum_{i}{x^p})^{1/p}
```
But correct formula is:
```
(\sum_{i}{|x|^p})^{1/p}
```
We can verify this using lectures (https://www.math.usm.edu/lambers/mat610/sum10/lecture2.pdf) or using Wolfram Mathematica:
```
> Norm[{x, y, z}, p]
(Abs[x]^p+Abs[y]^p+Abs[z]^p)^(1/p)
```
Issue: https://issues.apache.org/jira/browse/IGNITE-13392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zaleslaw merged pull request #8196: IGNITE-13392 [ML]: fix Incorrect Vector::kNorm evaluation for odd powers
Posted by GitBox <gi...@apache.org>.
zaleslaw merged pull request #8196:
URL: https://github.com/apache/ignite/pull/8196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zaleslaw merged pull request #8196: IGNITE-13392 [ML]: fix Incorrect Vector::kNorm evaluation for odd powers
Posted by GitBox <gi...@apache.org>.
zaleslaw merged pull request #8196:
URL: https://github.com/apache/ignite/pull/8196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zaleslaw commented on pull request #8196: IGNITE-13392: fix Incorrect Vector::kNorm evaluation for odd powers
Posted by GitBox <gi...@apache.org>.
zaleslaw commented on pull request #8196:
URL: https://github.com/apache/ignite/pull/8196#issuecomment-687167860
Looks good for me, I'll run TC yet once to attach to the ticket and will merge it next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org