You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/10 04:49:55 UTC
[GitHub] [rocketmq-externals] wlliqipeng opened a new pull request #511: Add
RocketMQSource for Knative
wlliqipeng opened a new pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511
## What is the purpose of the change
Add RocketMQSource for Knative, which can forward messages from rocketmq cluster to knative.
## Brief changelog
Add the project of rocketmq-source
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] vongosling commented on a change in pull
request #511: Add RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511#discussion_r376895094
##########
File path: rocketmq-knative/source/config/500-controller.yaml
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: rocketmqsource-controller-manager
+ namespace: knative-sources
+ labels:
+ control-plane: rocketmqsource-controller-manager
+spec:
+ selector:
+ matchLabels: &labels
+ control-plane: rocketmqsource-controller-manager
+ serviceName: rocketmqsource-controller-manager
+ template:
+ metadata:
+ labels: *labels
+ spec:
+ serviceAccountName: rocketmqsource-controller-manager
+ containers:
+ - name: manager
+ image: docker.io/wlliqipeng/alitablestore-controller-test:0.5.0
Review comment:
what is alitablestore-controller?
Does the iamge hosted in wlliqipeng namespace?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] vongosling merged pull request #511: Add
RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] vongosling commented on a change in pull
request #511: Add RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511#discussion_r376895094
##########
File path: rocketmq-knative/source/config/500-controller.yaml
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: rocketmqsource-controller-manager
+ namespace: knative-sources
+ labels:
+ control-plane: rocketmqsource-controller-manager
+spec:
+ selector:
+ matchLabels: &labels
+ control-plane: rocketmqsource-controller-manager
+ serviceName: rocketmqsource-controller-manager
+ template:
+ metadata:
+ labels: *labels
+ spec:
+ serviceAccountName: rocketmqsource-controller-manager
+ containers:
+ - name: manager
+ image: docker.io/wlliqipeng/alitablestore-controller-test:0.5.0
Review comment:
alitablestore-controller?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] wlliqipeng commented on a change in pull
request #511: Add RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
wlliqipeng commented on a change in pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511#discussion_r376912736
##########
File path: rocketmq-knative/source/config/500-controller.yaml
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: rocketmqsource-controller-manager
+ namespace: knative-sources
+ labels:
+ control-plane: rocketmqsource-controller-manager
+spec:
+ selector:
+ matchLabels: &labels
+ control-plane: rocketmqsource-controller-manager
+ serviceName: rocketmqsource-controller-manager
+ template:
+ metadata:
+ labels: *labels
+ spec:
+ serviceAccountName: rocketmqsource-controller-manager
+ containers:
+ - name: manager
+ image: docker.io/wlliqipeng/alitablestore-controller-test:0.5.0
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] wlliqipeng commented on a change in pull
request #511: Add RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
wlliqipeng commented on a change in pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511#discussion_r376908931
##########
File path: rocketmq-knative/source/config/500-controller.yaml
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: rocketmqsource-controller-manager
+ namespace: knative-sources
+ labels:
+ control-plane: rocketmqsource-controller-manager
+spec:
+ selector:
+ matchLabels: &labels
+ control-plane: rocketmqsource-controller-manager
+ serviceName: rocketmqsource-controller-manager
+ template:
+ metadata:
+ labels: *labels
+ spec:
+ serviceAccountName: rocketmqsource-controller-manager
+ containers:
+ - name: manager
+ image: docker.io/wlliqipeng/alitablestore-controller-test:0.5.0
Review comment:
sorry, the image is misquoted,I'll change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] vongosling commented on a change in pull
request #511: Add RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511#discussion_r376946628
##########
File path: rocketmq-knative/source/config/202-clusterrolebinding.yaml
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+ name: eventing-sources-rocketmq-controller
+subjects:
+- kind: ServiceAccount
+ name: rocketmqsource-controller-manager
+ namespace: knative-sources
+roleRef:
+ apiGroup: rbac.authorization.k8s.io
+ kind: ClusterRole
+ name: eventing-sources-rocketmq-controller
+
+---
+
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+ name: eventing-sources-alitablestore-resolver
Review comment:
where is eventing-sources-alitablestore-resolver?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-externals] vongosling commented on a change in pull
request #511: Add RocketMQSource for Knative
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #511: Add RocketMQSource for Knative
URL: https://github.com/apache/rocketmq-externals/pull/511#discussion_r377414345
##########
File path: rocketmq-knative/source/config/500-controller.yaml
##########
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+ name: rocketmqsource-controller-manager
+ namespace: knative-sources
+ labels:
+ control-plane: rocketmqsource-controller-manager
+spec:
+ selector:
+ matchLabels: &labels
+ control-plane: rocketmqsource-controller-manager
+ serviceName: rocketmqsource-controller-manager
+ template:
+ metadata:
+ labels: *labels
+ spec:
+ serviceAccountName: rocketmqsource-controller-manager
+ containers:
+ - name: manager
+ image: docker.io/wlliqipeng/rocketmqsource-controller:0.6.3
Review comment:
This docker image repo should be replaced when final release come out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services