You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/21 04:53:48 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #2728: esp32_dma_init: Fix a dubious assertion
yamt opened a new pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728
## Summary
Requiring the size to be a multiple of 3 is a very strange restriction.
It doesn't even work with the default value of SPI_SLAVE_BUFSIZE.
I guess it was a typo.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728#issuecomment-764314142
@donghengqaz can you confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz commented on pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
donghengqaz commented on pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728#issuecomment-764508446
Thanks for your fix, this is a typo. SPI DMA receiving data length should be aligned by 4 bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728#issuecomment-764314142
@donghengqaz can you confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz edited a comment on pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
donghengqaz edited a comment on pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728#issuecomment-764508446
@yamt Thanks for your fix, this is a typo. SPI DMA receiving data length should be aligned by 4 bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz commented on pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
donghengqaz commented on pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728#issuecomment-764508446
Thanks for your fix, this is a typo. SPI DMA receiving data length should be aligned by 4 bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz edited a comment on pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
donghengqaz edited a comment on pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728#issuecomment-764508446
@yamt Thanks for your fix, this is a typo. SPI DMA receiving data length should be aligned by 4 bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #2728: esp32_dma_init: Fix a dubious assertion
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2728:
URL: https://github.com/apache/incubator-nuttx/pull/2728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org