[GitHub] [skywalking] dmsolr edited a comment on issue #2730: Provide plugin for Solr-7.x(client)

[GitBox <gi...@apache.org>]

dmsolr edited a comment on issue #2730: Provide plugin for Solr-7.x(client)
URL: https://github.com/apache/skywalking/pull/2730#issuecomment-498121608
 
 
   @wu-sheng , I am sorry to reply so late.
   
   > Why this status doesn't match span status? Which values of these status?
   
   It looks like http status. But it uses `0` instead of `2xx` and uses `500` instead of less than `100`. 
   
   > Why doesn't this match the span duration? If this represents target(solr server) duration, we should have solr server trace in next step, right? Then we still don't need this.
   
   Yes. It represents elapsed time on server side. It exclude http, de/en-serialized time-consuming.
   
   > And in your example, could you tell me, what does mycore mean? Look like your operation name include it.
   
   That likes table name in SQL.  It consist of shards and replicas. If the request sends to the specified sharding, the operation name will use sharding name( it names `collectionName_shardingNum_replicaNum`). However collection name will be contained. So it can be removed.
   
   > About `docsSize`, `delete.by`.
   
   I think they are useful. `delete.by` likes deleting statement in SQL. I will move it to `db.statement`. `docsSize` represents the number of effected rows in the upserting.
   
   > commitWithin, softCommit, maxOptimizeSegs
   
   They may not be useful for single request analysis, but they let us know what is done to the server and what state the server is in. But for caller, they are really useless. For me, a ops of solr, they are a bit important. So they are opened through config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services