You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/10/24 23:19:49 UTC
[jclouds-site] Remove BlobMap and Map documentation (#22)
We deprecated these in 1.6 and removed them in 1.7.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds-site blob-map
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/22
-- Commit Summary --
* Remove BlobMap and Map documentation
-- File Changes --
M documentation/userguide/blobstore-guide.md (73)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/22.patch
https://github.com/jclouds/jclouds-site/pull/22.diff
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by Andrew Phillips <no...@github.com>.
> Should lines 276 to 299 from the userguide/compute (the 'working with credentials' section basically. Line highlight
> does not work on markdown files) be removed too?
Would these need to be removed, or perhaps simply reworded to point out that you would have to write the map implementation yourself, rather than being able to use BlobMap?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22#issuecomment-27125490
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master. Addressed nacx's comment about compute.markdown.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22#issuecomment-29594744
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by Andrew Phillips <no...@github.com>.
Formatting and rendering of the updated page looks fine, by the way.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22#issuecomment-27125583
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by Andrew Gaul <no...@github.com>.
> -BlobStoreContext context = ContextBuilder.newBuilder("aws-s3")
> - .credentials(identity, credential)
> - .buildView(BlobStoreContext.class);
> -BlobMap map = context.createBlobMap("adrian.photos");
> -
> -Blob blob = map.blobBuilder("sushi.jpg")
> - .payload(new File("sushi.jpg"))// or byte[]. InputStream, etc.
> - .contentDisposition("attachment; filename=sushi.jpg")
> - .contentType("image/jpeg")
> - .calculateMD5().build();
> -
> -map.put(blob.getName(), blob);
> -
> -context.close();
> -{% endhighlight %}
> +You can choose from two APIs: BlobStore and AsyncBlobStore.
AsyncBlobStore discussion out of scope of this commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22/files#r8017622
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by Ignasi Barrera <no...@github.com>.
Should lines 276 to 299 from the [userguide/compute](https://github.com/jclouds/jclouds-site/blob/master/documentation/userguide/compute.markdown) (the 'working with credentials' section basically. Line highlight does not work on markdown files) be removed too? Persistent credentials used the removed `InputStreamMap`, so that won't be available until [JCLOUDS-294](https://issues.apache.org/jira/browse/JCLOUDS-294) is resolved.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22#issuecomment-27033085
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by Andrew Phillips <no...@github.com>.
> -BlobStoreContext context = ContextBuilder.newBuilder("aws-s3")
> - .credentials(identity, credential)
> - .buildView(BlobStoreContext.class);
> -BlobMap map = context.createBlobMap("adrian.photos");
> -
> -Blob blob = map.blobBuilder("sushi.jpg")
> - .payload(new File("sushi.jpg"))// or byte[]. InputStream, etc.
> - .contentDisposition("attachment; filename=sushi.jpg")
> - .contentType("image/jpeg")
> - .calculateMD5().build();
> -
> -map.put(blob.getName(), blob);
> -
> -context.close();
> -{% endhighlight %}
> +You can choose from two APIs: BlobStore and AsyncBlobStore.
While we're at it, should we be marking the AsyncBlobStore as deprecated, or at least letting users know that the preferred way is to invoke BlobStore and handle async calls yourself by using an executor?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22/files#r7228288
Re: [jclouds-site] Remove BlobMap and Map documentation (#22)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #84](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/84/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/22#issuecomment-27031762