You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "TzeKai Lee (Created) (JIRA)" <se...@james.apache.org> on 2012/03/30 08:44:48 UTC

[jira] [Created] (JAMES-1397) Incorrect nesting level counting for matcher mbean name

Incorrect nesting level counting for matcher mbean name
-------------------------------------------------------

                 Key: JAMES-1397
                 URL: https://issues.apache.org/jira/browse/JAMES-1397
             Project: JAMES Server
          Issue Type: Bug
          Components: SpoolManager & Processors
            Reporter: TzeKai Lee
            Priority: Minor


The nesting level in the mbean name of composite matcher is incorrect if there are more than one composite matcher in the same nesting level.
Consider this:

<matcher name="composite" match="Or">
  <matcher match="And">
    <matcher match="SubjectIs=example"/>
  </matcher>
  <matcher match="And">
    <matcher match="SenderIsRegex=example.*"/>
  </matcher>
</matcher>

mbean name will be
SubjectIs: <parent part>subtype2=matcher,index2=0,matchername2=SubjectIs
SenderIsRegex: <parent part>subtype3=matcher,index3=0,matchername3=SenderIsRegex
first And: <parent part>subtype1=matcher,index1=0,matchername1=And
second And: <parent part>subtype1=matcher,index1=1,matchername1=And

nesting level of SenderIsRegex should be 2 instead of 3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Updated] (JAMES-1397) Incorrect nesting level counting for matcher mbean name

Posted by "Eric Charles (Updated) (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Charles updated JAMES-1397:
--------------------------------

    Assignee: Eric Charles

Thx for the patch Lee. I will test and commit if OK.
                
> Incorrect nesting level counting for matcher mbean name
> -------------------------------------------------------
>
>                 Key: JAMES-1397
>                 URL: https://issues.apache.org/jira/browse/JAMES-1397
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: SpoolManager & Processors
>            Reporter: TzeKai Lee
>            Assignee: Eric Charles
>            Priority: Minor
>         Attachments: fix_mbean_level.patch
>
>
> The nesting level in the mbean name of composite matcher is incorrect if there are more than one composite matcher in the same nesting level.
> Consider this:
> <matcher name="composite" match="Or">
>   <matcher match="And">
>     <matcher match="SubjectIs=example"/>
>   </matcher>
>   <matcher match="And">
>     <matcher match="SenderIsRegex=example.*"/>
>   </matcher>
> </matcher>
> mbean name will be
> SubjectIs: <parent part>subtype2=matcher,index2=0,matchername2=SubjectIs
> SenderIsRegex: <parent part>subtype3=matcher,index3=0,matchername3=SenderIsRegex
> first And: <parent part>subtype1=matcher,index1=0,matchername1=And
> second And: <parent part>subtype1=matcher,index1=1,matchername1=And
> nesting level of SenderIsRegex should be 2 instead of 3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Updated] (JAMES-1397) Incorrect nesting level counting for matcher mbean name

Posted by "TzeKai Lee (Updated) (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

TzeKai Lee updated JAMES-1397:
------------------------------

    Attachment: fix_mbean_level.patch

quick fix :)
                
> Incorrect nesting level counting for matcher mbean name
> -------------------------------------------------------
>
>                 Key: JAMES-1397
>                 URL: https://issues.apache.org/jira/browse/JAMES-1397
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: SpoolManager & Processors
>            Reporter: TzeKai Lee
>            Priority: Minor
>         Attachments: fix_mbean_level.patch
>
>
> The nesting level in the mbean name of composite matcher is incorrect if there are more than one composite matcher in the same nesting level.
> Consider this:
> <matcher name="composite" match="Or">
>   <matcher match="And">
>     <matcher match="SubjectIs=example"/>
>   </matcher>
>   <matcher match="And">
>     <matcher match="SenderIsRegex=example.*"/>
>   </matcher>
> </matcher>
> mbean name will be
> SubjectIs: <parent part>subtype2=matcher,index2=0,matchername2=SubjectIs
> SenderIsRegex: <parent part>subtype3=matcher,index3=0,matchername3=SenderIsRegex
> first And: <parent part>subtype1=matcher,index1=0,matchername1=And
> second And: <parent part>subtype1=matcher,index1=1,matchername1=And
> nesting level of SenderIsRegex should be 2 instead of 3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Closed] (JAMES-1397) Incorrect nesting level counting for matcher mbean name

Posted by "Eric Charles (Closed) (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Charles closed JAMES-1397.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0-beta5

Committed in trunk. Thx TzeKai Lee for the patch.
                
> Incorrect nesting level counting for matcher mbean name
> -------------------------------------------------------
>
>                 Key: JAMES-1397
>                 URL: https://issues.apache.org/jira/browse/JAMES-1397
>             Project: JAMES Server
>          Issue Type: Bug
>          Components: SpoolManager & Processors
>            Reporter: TzeKai Lee
>            Assignee: Eric Charles
>            Priority: Minor
>             Fix For: 3.0-beta5
>
>         Attachments: fix_mbean_level.patch
>
>
> The nesting level in the mbean name of composite matcher is incorrect if there are more than one composite matcher in the same nesting level.
> Consider this:
> <matcher name="composite" match="Or">
>   <matcher match="And">
>     <matcher match="SubjectIs=example"/>
>   </matcher>
>   <matcher match="And">
>     <matcher match="SenderIsRegex=example.*"/>
>   </matcher>
> </matcher>
> mbean name will be
> SubjectIs: <parent part>subtype2=matcher,index2=0,matchername2=SubjectIs
> SenderIsRegex: <parent part>subtype3=matcher,index3=0,matchername3=SenderIsRegex
> first And: <parent part>subtype1=matcher,index1=0,matchername1=And
> second And: <parent part>subtype1=matcher,index1=1,matchername1=And
> nesting level of SenderIsRegex should be 2 instead of 3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org