You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/02/23 21:12:54 UTC
Review Request 43896: Removed the restriction that /tmp needs to be
writable in new rootfs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43896/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Ian Downes, Jojy Varghese, and Timothy Chen.
Bugs: MESOS-4291
https://issues.apache.org/jira/browse/MESOS-4291
Repository: mesos
Description
-------
Removed the restriction that /tmp needs to be writable in new rootfs.
Diffs
-----
src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e
Diff: https://reviews.apache.org/r/43896/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 43896: Removed the restriction that /tmp needs to
be writable in new rootfs.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43896/#review120381
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/fs.cpp (line 600)
<https://reviews.apache.org/r/43896/#comment181824>
probably unnecessary but since this is specifically for the pivot you could limit the size and make noexec too?
src/linux/fs.cpp (line 603)
<https://reviews.apache.org/r/43896/#comment181822>
Clarify the message that it's a *temporary* tmpfs mount?
- Ian Downes
On Feb. 23, 2016, 12:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43896/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ian Downes, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4291
> https://issues.apache.org/jira/browse/MESOS-4291
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the restriction that /tmp needs to be writable in new rootfs.
>
>
> Diffs
> -----
>
> src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e
>
> Diff: https://reviews.apache.org/r/43896/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>