You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2009/04/05 17:35:11 UTC
Traling spaces
If nobody disagree I will soon replace all trailing spaces in all files (not only Java). I can't see any problems but if you see one please chime in
Jacques
Re: Traling spaces
Posted by Jacques Le Roux <ja...@les7arts.com>.
Done at r763175,
For contributors, if they follow the coding coventions we should not have any problems. The only issue is that maybe they will not
have a tool like anyedit.
Anyway all this is trival :o)
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
>I was to commit this changes but I wonder about something.
>
> Assertion : below when I speak about trailing spaces it can actually be also a mixtures of spaces and tabs
>
> We have trailing spaces and, what I call, *real* trailing spaces. Real trailing spaces are spaces at end of lines of codes or
> data. These should really not be and only depends of the developer good will, attention or experience.
>
> But if you use a standard editor (I mean a tool which don't include an automatic tool to remove trailing spaces) you are also
> generating spaces when, for instance, you create a blank line between 2 lines of code or data. Most of the time, they are also
> considered as "trailing" spaces (even if we can see that they are not at the end of anything) so they are removed by automatic
> tool like anyedit plugin in Eclipse (http://docs.ofbiz.org/x/mg). A standar editor will keep them and, I don't know for other
> tools like it, but anyedit is not able to differentiate between the 2 cases (no preferences options).
>
> So as I want to prevent the noise generated by anyedit removing trailing spaces, I want to remove all trailing spaces, not only
> real trailing spaces. This is why the commit is so big. But we can easily foresee that this will not completly prevent future
> noise, except if all commiters agree to use a tool like anyedit...
>
> Thanks for your attention, hell is in details (heaven too)
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
>>I should soon commit the changes, but before I have a question
>> 1) In Eclipse on Windows I had to change the encoding of all files from Cp1252 (which is the default for an Eclipse project
>> created
>> on Windows) to UTF8
>> 2) The patch size is 6.7 MB
>>
>> It's really huge but without any functional changes. I did a cursorily/random review (includng some tests), it should be ok but
>> does anybody see a problem with the 2 points above ? For the 2d, I mean maybe a better hour should be choosen to commit but as we
>> work all around the world, I can't see which one...
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <ja...@les7arts.com>
>> To: <de...@ofbiz.apache.org>
>> Sent: Sunday, April 05, 2009 5:35 PM
>> Subject: Traling spaces
>>
>>
>> If nobody disagree I will soon replace all trailing spaces in all files (not only Java). I can't see any problems but if you see
>> one
>> please chime in
>>
>> Jacques
>>
>>
>
>
Re: Traling spaces
Posted by Jacques Le Roux <ja...@les7arts.com>.
I was to commit this changes but I wonder about something.
Assertion : below when I speak about trailing spaces it can actually be also a mixtures of spaces and tabs
We have trailing spaces and, what I call, *real* trailing spaces. Real trailing spaces are spaces at end of lines of codes or data.
These should really not be and only depends of the developer good will, attention or experience.
But if you use a standard editor (I mean a tool which don't include an automatic tool to remove trailing spaces) you are also
generating spaces when, for instance, you create a blank line between 2 lines of code or data. Most of the time, they are also
considered as "trailing" spaces (even if we can see that they are not at the end of anything) so they are removed by automatic tool
like anyedit plugin in Eclipse (http://docs.ofbiz.org/x/mg). A standar editor will keep them and, I don't know for other tools like
it, but anyedit is not able to differentiate between the 2 cases (no preferences options).
So as I want to prevent the noise generated by anyedit removing trailing spaces, I want to remove all trailing spaces, not only real
trailing spaces. This is why the commit is so big. But we can easily foresee that this will not completly prevent future noise,
except if all commiters agree to use a tool like anyedit...
Thanks for your attention, hell is in details (heaven too)
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
>I should soon commit the changes, but before I have a question
> 1) In Eclipse on Windows I had to change the encoding of all files from Cp1252 (which is the default for an Eclipse project
> created
> on Windows) to UTF8
> 2) The patch size is 6.7 MB
>
> It's really huge but without any functional changes. I did a cursorily/random review (includng some tests), it should be ok but
> does anybody see a problem with the 2 points above ? For the 2d, I mean maybe a better hour should be choosen to commit but as we
> work all around the world, I can't see which one...
>
> Thanks
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
> To: <de...@ofbiz.apache.org>
> Sent: Sunday, April 05, 2009 5:35 PM
> Subject: Traling spaces
>
>
> If nobody disagree I will soon replace all trailing spaces in all files (not only Java). I can't see any problems but if you see
> one
> please chime in
>
> Jacques
>
>
Re: Traling spaces
Posted by Jacques Le Roux <ja...@les7arts.com>.
I should soon commit the changes, but before I have a question
1) In Eclipse on Windows I had to change the encoding of all files from Cp1252 (which is the default for an Eclipse project created
on Windows) to UTF8
2) The patch size is 6.7 MB
It's really huge but without any functional changes. I did a cursorily/random review (includng some tests), it should be ok but does
anybody see a problem with the 2 points above ? For the 2d, I mean maybe a better hour should be choosen to commit but as we work
all around the world, I can't see which one...
Thanks
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
To: <de...@ofbiz.apache.org>
Sent: Sunday, April 05, 2009 5:35 PM
Subject: Traling spaces
If nobody disagree I will soon replace all trailing spaces in all files (not only Java). I can't see any problems but if you see one
please chime in
Jacques