You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/05/21 07:47:54 UTC
[GitHub] [cordova-plugin-splashscreen] erisu opened a new pull request #263: breaking: remove ios platform code from plugin repo
erisu opened a new pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263
### Platforms affected
ios
### Motivation and Context
* SplashScreen plugin is no longer needed for Cordova iOS 6.x. The plugin code has been integrated.
* Cordova iOS 6.x will only support the Launch Storyboard. The `README.md` will retain iOS related docs so that the all SplashScreen docs on `cordova.io` will continue to be grouped.
### Description
* remove all ios code
* remove ios from tests
* update SplashScreen docs to only talk about iOS Launch Storyboard
### Checklist
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu merged pull request #263: breaking: remove ios platform code from plugin repo
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on a change in pull request #263: breaking: remove ios platform code from plugin repo
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on a change in pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263#discussion_r445603962
##########
File path: package.json
##########
@@ -36,9 +34,6 @@
"cordova-android": ">=3.6.0",
"cordova-windows": ">=4.4.0"
},
- "<6.0.0": {
- "cordova-ios": "<6.0.0"
- },
"6.0.0": {
Review comment:
this should be bumped to 7 or it won't install
```suggestion
"7.0.0": {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] NiklasMerz commented on pull request #263: breaking: remove ios platform code from plugin repo
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263#issuecomment-649709494
No sorry Github is broken. Travis has a build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] zeshanb commented on pull request #263: breaking: remove ios platform code from plugin repo
Posted by GitBox <gi...@apache.org>.
zeshanb commented on pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263#issuecomment-950393757
I am also having iOS "Launch Screen" issues.
The Images are suppose to appear in this directory:
The Images.xcassets directory is located under resources iOS Xcode project:
Bare minimum only the following images were required:
- default-2.png at 320 x 480 pixels
- default-568h@2x-1.png at 640 x 1136
- default-portrait-736h@3x-1.png at 1242 x 2208
- default@2x-1.png at 640x960
The Xcode interface generates a .json file and the .json file is placed in LaunchStoryboard.imageset directory. Only few images are required. Here is a sample of the json file:
````````````
{
"images" : [
{
"filename" : "default-2.png",
"idiom" : "universal",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "universal",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "universal",
"scale" : "1x"
},
{
"filename" : "default-568h@2x-1.png",
"idiom" : "universal",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "universal",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "universal",
"scale" : "2x"
},
{
"filename" : "default-portrait-736h@3x-1.png",
"idiom" : "universal",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "universal",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "universal",
"scale" : "3x"
},
{
"height-class" : "compact",
"idiom" : "universal",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "1x"
},
{
"height-class" : "compact",
"idiom" : "universal",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "2x"
},
{
"height-class" : "compact",
"idiom" : "universal",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "3x"
},
{
"idiom" : "universal",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "universal",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "universal",
"scale" : "1x",
"width-class" : "compact"
},
{
"idiom" : "universal",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "universal",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "universal",
"scale" : "2x",
"width-class" : "compact"
},
{
"idiom" : "universal",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "universal",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "universal",
"scale" : "3x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "universal",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "1x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "universal",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "2x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "universal",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "universal",
"scale" : "3x",
"width-class" : "compact"
},
{
"idiom" : "iphone",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "iphone",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "iphone",
"scale" : "1x"
},
{
"idiom" : "iphone",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "iphone",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "iphone",
"scale" : "2x"
},
{
"idiom" : "iphone",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "iphone",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "iphone",
"scale" : "3x"
},
{
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "1x"
},
{
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "2x"
},
{
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "3x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "3x"
},
{
"idiom" : "iphone",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "iphone",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "iphone",
"scale" : "1x",
"width-class" : "compact"
},
{
"idiom" : "iphone",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "iphone",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "iphone",
"scale" : "2x",
"width-class" : "compact"
},
{
"idiom" : "iphone",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "iphone",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "iphone",
"scale" : "3x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "1x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "2x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "3x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "iphone",
"scale" : "3x",
"width-class" : "compact"
},
{
"filename" : "default-3.png",
"idiom" : "ipad",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "ipad",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "ipad",
"scale" : "1x"
},
{
"filename" : "default@2x-1.png",
"idiom" : "ipad",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "ipad",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "ipad",
"scale" : "2x"
},
{
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "1x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "1x"
},
{
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "2x"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "2x"
},
{
"idiom" : "ipad",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "ipad",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "ipad",
"scale" : "1x",
"width-class" : "compact"
},
{
"idiom" : "ipad",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"idiom" : "ipad",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"idiom" : "ipad",
"scale" : "2x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "1x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "1x",
"width-class" : "compact"
},
{
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "light"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "2x",
"width-class" : "compact"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"height-class" : "compact",
"idiom" : "ipad",
"scale" : "2x",
"width-class" : "compact"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
````````````
I would appreciate if this issue can be resolved at your convenience. Thank you for your time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on a change in pull request #263: breaking: remove ios platform code from plugin repo
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263#discussion_r445713367
##########
File path: package.json
##########
@@ -36,9 +34,6 @@
"cordova-android": ">=3.6.0",
"cordova-windows": ">=4.4.0"
},
- "<6.0.0": {
- "cordova-ios": "<6.0.0"
- },
"6.0.0": {
Review comment:
I will do that change in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] NiklasMerz commented on pull request #263: breaking: remove ios platform code from plugin repo
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #263:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/263#issuecomment-649708940
Why has this PR no Travis Run? Is the travis.yml broken or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org