[GitHub] [ozone] neils-dev commented on a diff in pull request #4110: HDDS-5560. Updating clusterId to correct value

["neils-dev (via GitHub)" <gi...@apache.org>]

neils-dev commented on code in PR #4110:
URL: https://github.com/apache/ozone/pull/4110#discussion_r1096439402


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/DatanodeLayoutStorage.java:
##########
@@ -64,6 +64,11 @@ protected Properties getNodeProperties() {
     return new Properties();
   }
 
+  @Override
+  public void setClusterId(String clusterId) throws IOException {
+    super.getStorageInfo().setClusterId(clusterId);

Review Comment:
   Thanks @nishitpatira for this patch.  We don't need to override the `setClusterId` method here.  There is already an implementation provided by the `abstract Storage class`.  Not needed here, just use the base class implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org