[GitHub] [pulsar] momo-jun commented on a diff in pull request #15137: [PIP-153][optimize][txn] Optimize metadataPositions in MLPendingAckStore

[GitBox <gi...@apache.org>]

momo-jun commented on code in PR #15137:
URL: https://github.com/apache/pulsar/pull/15137#discussion_r872149531


##########
conf/broker.conf:
##########
@@ -1402,6 +1402,12 @@ transactionBufferSnapshotMinTimeInMillis=5000
 # The max concurrent requests for transaction buffer client, default is 1000
 transactionBufferClientMaxConcurrentRequests=1000
 
+# MLPendingAckStore maintain a ConcurrentSkipListMap pendingAckLogIndex`,
+# it store the position in pendingAckStore as value and save a position used to determine

Review Comment:
   ```suggestion
   # It stores the position in pendingAckStore as its value and saves a position used to determine
   ```



##########
conf/broker.conf:
##########
@@ -1402,6 +1402,12 @@ transactionBufferSnapshotMinTimeInMillis=5000
 # The max concurrent requests for transaction buffer client, default is 1000
 transactionBufferClientMaxConcurrentRequests=1000
 
+# MLPendingAckStore maintain a ConcurrentSkipListMap pendingAckLogIndex`,

Review Comment:
   ```suggestion
   # MLPendingAckStore maintains a ConcurrentSkipListMap pendingAckLogIndex`,
   ```
   There is only one ` in the sentence. Did it miss the other one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org