[jira] [Commented] (GEODE-4746) Protobuf server should catch Exceptions and return a reasonable response message to clients

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381037#comment-16381037 ] 

ASF subversion and git services commented on GEODE-4746:
--------------------------------------------------------

Commit efc413ad68a73f581e9a84856c6ea379016e8b3d in geode's branch refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=efc413a ]

GEODE-4746: Handle exceptions and return failures to protobuf clients

Catching exceptions that happen before sending a response to the
protobuf client and sending an error message to the client instead of
closing the connection.

Cleaning up extraneous catch blocks.


> Protobuf server should catch Exceptions and return a reasonable response message to clients
> -------------------------------------------------------------------------------------------
>
>                 Key: GEODE-4746
>                 URL: https://issues.apache.org/jira/browse/GEODE-4746
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Whenever possible, the protobuf server should catch exceptions and send a response message back to the client. Currently, any exception on the server is causing the server to close the socket, even for trivial things like a typo in a query string. From the client side there is no information about why the socket was closed.
> We should catch exceptions and return the error message to the client without closing the socket.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)