You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/22 01:50:41 UTC
[GitHub] [james-project] chibenwa opened a new pull request #448: [POC] Mailet processing without Camel
chibenwa opened a new pull request #448:
URL: https://github.com/apache/james-project/pull/448
Addresses issues of https://github.com/apache/james-project/pull/447
Special care had been taken to dispose splitted/duplicated emails.
The split away from Camel is partial - one might want to:
- [ ] Get rid of the Camel dependency
- [ ] Rename maven package, classes, etc...
- [ ] Get rid of inheritance and favor composition
I opened it to get a full build and thus identify potential issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #448: JAMES-3589 [POC] Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-846357359
Ok, got a :green_apple: build on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #448: JAMES-3589 Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-862130229
Rebased and squashed fixups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #448: JAMES-3589 Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-852920230
> Did you see some improvement in build or launch time by the way?
- I saw a marginal improvments on the mailet runtime. Likely 1-5% according to the benchs async-profiler flame graphs.
- JMAP RFC-8621 memory now runs sub-100 ms after warmup.
- I will evaluate the gains in term of image gains
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on pull request #448: JAMES-3589 [POC] Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
rouazana commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-852848084
No problem for me for removing camel. Did you see some improvement in build or launch time by the way? As far as I remember it was slowing down James' startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on pull request #448: JAMES-3589 [POC] Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
rouazana commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-852848677
No problem for me for removing camel. Did you see some improvement in build or launch time by the way? As far as I remember it was slowing down James' startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #448: JAMES-3589 [POC] Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #448:
URL: https://github.com/apache/james-project/pull/448#discussion_r637660876
##########
File path: server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/camel/MatcherSplitter.java
##########
@@ -155,6 +155,8 @@ public MatcherSplitter(MetricFactory metricFactory, CamelMailetProcessor contain
Mail newMail = MailImpl.duplicate(mail);
newMail.setRecipients(matchedRcpts);
+ newMail.setState(mail.getState());
+ mail.setRecipients(rcpts);
Review comment:
That's already set up few lines above (154). Any reason to do it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on pull request #448: JAMES-3589 [POC] Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
rouazana commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-852852291
No problem for me for removing camel. Did you see some improvement in build or launch time by the way? As far as I remember it was slowing down James' startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa edited a comment on pull request #448: JAMES-3589 Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
chibenwa edited a comment on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-852920230
> Did you see some improvement in build or launch time by the way?
- I saw a marginal improvments on the mailet runtime. Likely 1-5% according to the benchs async-profiler flame graphs.
- JMAP RFC-8621 memory now runs sub-100 ms after warmup.
- I will evaluate the gains in term of image gains (edit: gains: 10 MB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #448: JAMES-3589 Mailet processing without Camel
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #448:
URL: https://github.com/apache/james-project/pull/448#issuecomment-855404500
(Just rebased to solve conflict)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org