You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by conker84 <gi...@git.apache.org> on 2017/06/19 21:04:39 UTC

[GitHub] zeppelin pull request #2421: [ZEPPELIN-2663] Helium vizualisations do not ap...

GitHub user conker84 opened a pull request:

    https://github.com/apache/zeppelin/pull/2421

    [ZEPPELIN-2663] Helium vizualisations do not appear in the list of builtInt visualizations in paragraph

    ### What is this PR for?
    Within the helium only default build in visualizations are in the list of possible visualizations
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [x] - Correct the bug
    
    ### What is the Jira issue?
    [ZEPPELIN-2663](https://issues.apache.org/jira/browse/ZEPPELIN-2663)
    
    ### How should this be tested?
    * git clone zeppelin
    * mvn clean package
    * run, open browser
    * go to helium
    * enable few additional visualizations
    * create new note and add paragraph: print("%table text\tme\n")
    
    ### Screenshots (if appropriate)
    No
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/conker84/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2421
    
----
commit 5d8e50e365dfce949f08f5334e683e82475e9029
Author: conker84 <sa...@gmail.com>
Date:   2017-06-19T21:02:17Z

    Bugfix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2421: [ZEPPELIN-2663] Helium vizualisations do not ap...

Posted by conker84 <gi...@git.apache.org>.

Github user conker84 closed the pull request at:

    https://github.com/apache/zeppelin/pull/2421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    1. I checked manually `testSparkInterpreterDependencyLoading` in this branch. It works.
    2. Helium icons now appear. 
    
    @conker84 Could you please rebase?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    @conker84 Could you close and reopen this issue? to trigger the jenkins (not travis CI) again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    Then it might be not flaky tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by conker84 <gi...@git.apache.org>.

Github user conker84 commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    Thanks, here is the first one:
    ```bash
    Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 355.916 sec <<< FAILURE! - in org.apache.zeppelin.integration.SparkParagraphIT
    testDep(org.apache.zeppelin.integration.SparkParagraphIT)  Time elapsed: 278.752 sec  <<< ERROR!
    org.openqa.selenium.TimeoutException: Timed out after 60 seconds waiting for org.apache.zeppelin.AbstractZeppelinIT$1@411dba55
    Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
    System info: host: 'testing-docker-a579abe9-166d-4cd9-9117-34adab885d42', ip: '172.17.0.6', os.name: 'Linux', os.arch: 'amd64', os.version: '4.8.12-040812-generic', java.version: '1.7.0_76'
    Driver info: driver.version: unknown
    	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
    	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    	at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
    	at org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:206)
    	at org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:158)
    	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:647)
    	at org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:353)
    	at org.openqa.selenium.remote.RemoteWebDriver.findElementByXPath(RemoteWebDriver.java:490)
    	at org.openqa.selenium.By$ByXPath.findElement(By.java:361)
    	at org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:345)
    	at org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:96)
    	at org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:94)
    	at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:238)
    	at org.apache.zeppelin.AbstractZeppelinIT.pollingWait(AbstractZeppelinIT.java:94)
    	at org.apache.zeppelin.AbstractZeppelinIT.waitForParagraph(AbstractZeppelinIT.java:68)
    	at org.apache.zeppelin.integration.SparkParagraphIT.testDep(SparkParagraphIT.java:241)
    Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[contains(@class, 'control')]//span[2][contains(.,'ERROR')]"}
    For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
    Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
    System info: host: 'testing-docker-a579abe9-166d-4cd9-9117-34adab885d42', ip: '172.17.0.6', os.name: 'Linux', os.arch: 'amd64', os.version: '4.8.12-040812-generic', java.version: '1.7.0_76'
    Driver info: driver.version: unknown
    	at <anonymous class>.FirefoxDriver.prototype.findElementInternal_(file:///tmp/anonymous5059848591788447270webdriver-profile/extensions/fxdriver@googlecode.com/components/driver-component.js:10659)
    	at <anonymous class>.fxdriver.Timer.prototype.setTimeout/<.notify(file:///tmp/anonymous5059848591788447270webdriver-profile/extensions/fxdriver@googlecode.com/components/driver-component.js:621)
    ```
    And the second:
    
    ```bash
    Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 280.408 sec <<< FAILURE! - in org.apache.zeppelin.integration.ZeppelinIT
    testSparkInterpreterDependencyLoading(org.apache.zeppelin.integration.ZeppelinIT)  Time elapsed: 112.559 sec  <<< ERROR!
    org.openqa.selenium.TimeoutException: Timed out after 60 seconds waiting for org.apache.zeppelin.AbstractZeppelinIT$1@c3d6fb9
    Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
    System info: host: 'testing-docker-a579abe9-166d-4cd9-9117-34adab885d42', ip: '172.17.0.6', os.name: 'Linux', os.arch: 'amd64', os.version: '4.8.12-040812-generic', java.version: '1.7.0_76'
    Driver info: driver.version: unknown
    	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
    	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    	at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
    	at org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:206)
    	at org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:158)
    	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:647)
    	at org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:353)
    	at org.openqa.selenium.remote.RemoteWebDriver.findElementByXPath(RemoteWebDriver.java:490)
    	at org.openqa.selenium.By$ByXPath.findElement(By.java:361)
    	at org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:345)
    	at org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:96)
    	at org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:94)
    	at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:238)
    	at org.apache.zeppelin.AbstractZeppelinIT.pollingWait(AbstractZeppelinIT.java:94)
    	at org.apache.zeppelin.AbstractZeppelinIT.waitForParagraph(AbstractZeppelinIT.java:68)
    	at org.apache.zeppelin.integration.ZeppelinIT.testSparkInterpreterDependencyLoading(ZeppelinIT.java:249)
    Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[contains(@class, 'control')]//span[2][contains(.,'FINISHED')]"}
    For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
    Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
    System info: host: 'testing-docker-a579abe9-166d-4cd9-9117-34adab885d42', ip: '172.17.0.6', os.name: 'Linux', os.arch: 'amd64', os.version: '4.8.12-040812-generic', java.version: '1.7.0_76'
    Driver info: driver.version: unknown
    	at <anonymous class>.FirefoxDriver.prototype.findElementInternal_(file:///tmp/anonymous8818205536991534854webdriver-profile/extensions/fxdriver@googlecode.com/components/driver-component.js:10659)
    	at <anonymous class>.fxdriver.Timer.prototype.setTimeout/<.notify(file:///tmp/anonymous8818205536991534854webdriver-profile/extensions/fxdriver@googlecode.com/components/driver-component.js:621)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    I think it's flaky tests. Could you restart the failed job few times again? 
    
    ```
    # failed to check that job is finished.
    
    span[2][contains(.,'FINISHED')]"}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by conker84 <gi...@git.apache.org>.

Github user conker84 commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    I tried to restart the job several times but it still fails


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by conker84 <gi...@git.apache.org>.

Github user conker84 commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    @1ambda the CI it's finally green :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    Tested and LGTM.
    
    Merge to master as a Hotfix as it fixes broken feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by conker84 <gi...@git.apache.org>.

Github user conker84 commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    @1ambda the fork is up to date, i just restarted the job once time again, let's see
    Thanks for the support!
    Andrea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2421: [ZEPPELIN-2663] Helium vizualisations do not appear in...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2421
  
    Thanks for the contribution. Could fix the failed jobs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---