You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/28 12:17:33 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #21249: Refactor pipeline task and runner
sandynz opened a new pull request, #21249:
URL: https://github.com/apache/shardingsphere/pull/21249
Changes proposed in this pull request:
- Refactor AbstractLifecycleExecutor, doStart() to runBlocking(), and then stop() just after running completed
- Remove `extends AbstractLifecycleExecutor` for InventoryTask and IncrementalTask, and `start()` won't blocking, it'll be blocked in InventoryIncrementalTasksRunner
- Refactor `ExecuteEngine` to use CompletableFuture; Refactor InventoryTask and IncrementalTask to use ExecuteEngine and remove them in InventoryIncrementalTasksRunner, and refactor related classes
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin merged pull request #21249: Refactor pipeline task and runner
Posted by GitBox <gi...@apache.org>.
tuichenchuxin merged PR #21249:
URL: https://github.com/apache/shardingsphere/pull/21249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21249: Refactor pipeline task and runner
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21249:
URL: https://github.com/apache/shardingsphere/pull/21249#issuecomment-1261130211
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21249](https://codecov.io/gh/apache/shardingsphere/pull/21249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fa6ac8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a596551ee02c7e3ea86614e0568630beb1fba0cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a596551) will **increase** coverage by `0.10%`.
> The diff coverage is `67.77%`.
```diff
@@ Coverage Diff @@
## master #21249 +/- ##
============================================
+ Coverage 61.49% 61.60% +0.10%
- Complexity 2551 2555 +4
============================================
Files 4096 4111 +15
Lines 56440 56680 +240
Branches 7504 7541 +37
============================================
+ Hits 34709 34916 +207
- Misses 18793 18813 +20
- Partials 2938 2951 +13
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ition/value/AlwaysFalseShardingConditionValue.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi92YWx1ZS9BbHdheXNGYWxzZVNoYXJkaW5nQ29uZGl0aW9uVmFsdWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...esher/type/CreateViewStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9DcmVhdGVWaWV3U3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | `10.00% <0.00%> (+0.90%)` | :arrow_up: |
| [...peline/api/executor/AbstractLifecycleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL2V4ZWN1dG9yL0Fic3RyYWN0TGlmZWN5Y2xlRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...i/impl/AbstractInventoryIncrementalJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvYXBpL2ltcGwvQWJzdHJhY3RJbnZlbnRvcnlJbmNyZW1lbnRhbEpvYkFQSUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...xt/AbstractInventoryIncrementalProcessContext.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvY29udGV4dC9BYnN0cmFjdEludmVudG9yeUluY3JlbWVudGFsUHJvY2Vzc0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...here/data/pipeline/core/execute/ExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvZXhlY3V0ZS9FeGVjdXRlRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/data/pipeline/core/importer/DefaultImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW1wb3J0ZXIvRGVmYXVsdEltcG9ydGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ne/core/ingest/dumper/AbstractInventoryDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2R1bXBlci9BYnN0cmFjdEludmVudG9yeUR1bXBlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...a/pipeline/core/prepare/InventoryTaskSplitter.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvcHJlcGFyZS9JbnZlbnRvcnlUYXNrU3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...phere/data/pipeline/core/task/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvdGFzay9JbmNyZW1lbnRhbFRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/shardingsphere/pull/21249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org