[GitHub] [arrow-datafusion] alamb commented on a change in pull request #605: fix join column handling logic for `On` and `Using` constraints

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #605:
URL: https://github.com/apache/arrow-datafusion/pull/605#discussion_r657121001



##########
File path: datafusion/src/execution/context.rs
##########
@@ -1259,6 +1259,96 @@ mod tests {
         Ok(())
     }
 
+    #[tokio::test]
+    async fn left_join_using() -> Result<()> {

Review comment:
       👍  definitely an improvement
   

##########
File path: datafusion/src/logical_plan/dfschema.rs
##########
@@ -387,6 +402,9 @@ impl Display for DFSchema {
 pub struct DFField {
     /// Optional qualifier (usually a table or relation name)
     qualifier: Option<String>,
+    /// Optional set of qualifiers that all share this same field. This is used for `JOIN USING`

Review comment:
       it is confusing to me that the field would have multiple shared_qualifiers or a single qualifier or maybe both.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org