You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/16 13:55:18 UTC

[GitHub] [apisix] jbampton opened a new pull request #3313: docs: fix Markdown links and use lowercase anchors

jbampton opened a new pull request #3313:
URL: https://github.com/apache/apisix/pull/3313


   ### What this PR does / why we need it:
   
   Standardizes the Markdown files.
   
   ### Pre-submission checklist:
   
   * [X] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] juzhiyuan commented on a change in pull request #3313: docs: fix Markdown links and use lowercase anchors

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #3313:
URL: https://github.com/apache/apisix/pull/3313#discussion_r558896777



##########
File path: doc/zh-cn/discovery.md
##########
@@ -23,12 +23,12 @@
 * [**摘要**](#摘要)
 * [**如何扩展注册中心**](#如何扩展注册中心)
     * [**基本步骤**](#基本步骤)
-    * [**以 Eureka 举例**](#以-Eureka-举例)
+    * [**以 Eureka 举例**](#以-eureka-举例)
         * [**实现 eureka.lua**](#实现-eurekalua)
-        * [**Eureka 与 APISIX 之间数据转换逻辑**](#Eureka-与-APISIX-之间数据转换逻辑)
+        * [**Eureka 与 APISIX 之间数据转换逻辑**](#eureka-与-APISIX-之间数据转换逻辑)

Review comment:
       good good




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #3313: docs: fix Markdown link

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3313:
URL: https://github.com/apache/apisix/pull/3313


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] juzhiyuan commented on a change in pull request #3313: docs: fix Markdown links and use lowercase anchors

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #3313:
URL: https://github.com/apache/apisix/pull/3313#discussion_r558894489



##########
File path: doc/zh-cn/discovery.md
##########
@@ -23,12 +23,12 @@
 * [**摘要**](#摘要)
 * [**如何扩展注册中心**](#如何扩展注册中心)
     * [**基本步骤**](#基本步骤)
-    * [**以 Eureka 举例**](#以-Eureka-举例)
+    * [**以 Eureka 举例**](#以-eureka-举例)
         * [**实现 eureka.lua**](#实现-eurekalua)
-        * [**Eureka 与 APISIX 之间数据转换逻辑**](#Eureka-与-APISIX-之间数据转换逻辑)
+        * [**Eureka 与 APISIX 之间数据转换逻辑**](#eureka-与-APISIX-之间数据转换逻辑)

Review comment:
       Why we need lowercase?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] jbampton commented on a change in pull request #3313: docs: fix Markdown links and use lowercase anchors

Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #3313:
URL: https://github.com/apache/apisix/pull/3313#discussion_r558895444



##########
File path: doc/zh-cn/discovery.md
##########
@@ -23,12 +23,12 @@
 * [**摘要**](#摘要)
 * [**如何扩展注册中心**](#如何扩展注册中心)
     * [**基本步骤**](#基本步骤)
-    * [**以 Eureka 举例**](#以-Eureka-举例)
+    * [**以 Eureka 举例**](#以-eureka-举例)
         * [**实现 eureka.lua**](#实现-eurekalua)
-        * [**Eureka 与 APISIX 之间数据转换逻辑**](#Eureka-与-APISIX-之间数据转换逻辑)
+        * [**Eureka 与 APISIX 之间数据转换逻辑**](#eureka-与-APISIX-之间数据转换逻辑)

Review comment:
       The old syntax does work but most of the codebase is using lowercase anchors.  
   
   We should have one standard and consistent way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #3313: docs: fix Markdown links and use lowercase anchors

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3313:
URL: https://github.com/apache/apisix/pull/3313#discussion_r558898963



##########
File path: doc/zh-cn/discovery.md
##########
@@ -23,12 +23,12 @@
 * [**摘要**](#摘要)
 * [**如何扩展注册中心**](#如何扩展注册中心)
     * [**基本步骤**](#基本步骤)
-    * [**以 Eureka 举例**](#以-Eureka-举例)
+    * [**以 Eureka 举例**](#以-eureka-举例)

Review comment:
       I think it is fine to use `Eureka`? As we use Python instead of python.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org