[jira] [Commented] (OFBIZ-5704) Extend lot entity to include party Id of manufacturer

["Scott Gray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255283#comment-14255283 ] 

Scott Gray commented on OFBIZ-5704:
-----------------------------------

It seems the contentious debate here is whether there should be a manufacturerPartyId on the Lot entity or if we should support the ability to assign multiple parties in various roles to a Lot using a new LotRole entity.

There is nothing inherently wrong with using a manufacturerPartyId field if that is all that the currently known requirements dictate.  The reason not to is because the data model is a pain to change if we later decide we need to be able to assign more parties to a Lot.

So my opinion is that unless we know of a use case for multiple party assignment to Lots then we should use Pierre's single party assignment approach.  If we do know of a use case for multi party assignment to Lots then I agree with Adrian the a LotRole entity would make more sense.  But without known use cases we can't even be sure that a LotRole entity would fill a useful need when there's the possibility that each party assignment would require different supplementary data and thus require a completely different data model design.

Adrian, IMO it is not fair to disagree and claim a design flawed without at least providing a real world use case (even if only hypothetical) that the design fails to accommodate.

tldr: If we don't have a use case for multiple parties then let's use Pierre's approach.

> Extend lot entity to include party Id of manufacturer
> -----------------------------------------------------
>
>                 Key: OFBIZ-5704
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5704
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: manufacturing, product, workeffort
>    Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk
>            Reporter: Pierre Smits
>         Attachments: OFBiz-5704-Product-EntityModel-Lot.patch, Screen Shot 2014-09-03 at 13.52.47.png
>
>
> Rationale
> Lot or batch management affects two places, namely the outbound process (and its functionalities) and inbound. 
> It is possible that multiple parties have the same ID for the batch or the lot. Howver, in current feature set there is no discrimination between lots from supplier A, supplier B, or even the primary (internal) company in OFBiz.
> Therefore the entity 'Lot' should be extended with another key, namely that of the partyId of the manufacturer (or supplier).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)