You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SSRico <gi...@git.apache.org> on 2014/06/19 19:01:40 UTC

[GitHub] cordova-plugin-media-capture pull request: CB-6959] Port capture t...

GitHub user SSRico opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/19

    CB-6959] Port capture tests to plugin-test-framework

    Ported capture tests from mobile-spec to the new test framework working
    with jasmine 2.0.
    
    Added:
    -New js-module named tests to plugin.xml
    -Folder with tests.js

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SSRico/cordova-plugin-media-capture CB-6959

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit b2320e39d005e93787794e7f6fe64cfaf7071d46
Author: Samir Silva <ss...@gmail.com>
Date:   2014-06-19T18:59:57Z

    CB-6959] Port capture tests to plugin-test-framework
    
    Ported capture tests from mobile-spec to the new test framework working
    with jasmine 2.0.
    
    Added:
    -New js-module named tests to plugin.xml
    -Folder with tests.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media-capture pull request: CB-6959] Port capture t...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-media-capture/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-media-capture pull request: CB-6959] Port capture t...

Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/19#issuecomment-47386709
  
    Looks good, but as per the ML discussion we don't want tests to be included in the release version of the plugin. Please create a new PR with the test either in its own plugin or with some tooling changes to make things work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---