You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "JimGalasyn (via GitHub)" <gi...@apache.org> on 2024/06/07 19:27:16 UTC
[PR] MINOR: Update docs for for KIP-671 [kafka]
JimGalasyn opened a new pull request, #16247:
URL: https://github.com/apache/kafka/pull/16247
Add example code for [KIP-671: Introduce Kafka Streams Specific Uncaught Exception Handler](https://cwiki.apache.org/confluence/display/KAFKA/KIP-671%3A+Introduce+Kafka+Streams+Specific+Uncaught+Exception+Handler).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update docs for for KIP-671 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #16247:
URL: https://github.com/apache/kafka/pull/16247#discussion_r1631704904
##########
docs/streams/developer-guide/write-streams.html:
##########
@@ -152,17 +152,20 @@ <h2>Using Kafka Streams within your application code<a class="headerlink" href="
<p>To catch any unexpected exceptions, you can set an <code class="docutils literal"><span class="pre">java.lang.Thread.UncaughtExceptionHandler</span></code> before you start the
application. This handler is called whenever a stream thread is terminated by an unexpected exception:</p>
<pre class="line-numbers"><code class="language-java">// Java 8+, using lambda expressions
-streams.setUncaughtExceptionHandler((Thread thread, Throwable throwable) -> {
- // here you should examine the throwable/exception and perform an appropriate action!
-});
+streams.setUncaughtExceptionHander((exception) -> StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse.REPLACE_THREAD);
+// Java 7, using a concrete implementation
Review Comment:
Should we remove the Java 7 example? Java 7 is not supported any longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update docs for for KIP-671 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #16247:
URL: https://github.com/apache/kafka/pull/16247#issuecomment-2155583152
Thanks @JimGalasyn -- merged to `trunk` and cherry-picked to `3.8` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update docs for for KIP-671 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #16247:
URL: https://github.com/apache/kafka/pull/16247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org