You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/07/25 00:18:15 UTC
Re: Review Request 11161: Don't accept offers on the same host/port.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/
-----------------------------------------------------------
(Updated July 24, 2013, 10:18 p.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Repository: mesos
Description
-------
Don't accept offers on the same host/port.
We'll try to find a port combination that hasn't already been used to
launch a TaskTracker.
Review: https://reviews.apache.org/r/11161/
Diffs (updated)
-----
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 279f84e0f0c43ad3cfd9e4442010e706ee3565d9
Diff: https://reviews.apache.org/r/11161/diff/
Testing
-------
Used in production at airbnb.
make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
Thanks,
Brenden Matthews
Re: Review Request 11161: Don't accept offers on the same host/port.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On July 24, 2013, 11:51 p.m., Vinod Kone wrote:
> > Did you get any logs to indicate why this was happening in the first place? The comments seem to suggest we were waiting for more data to diagnose this.
I haven't seen this in a long time, but I still would like to keep this change.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/#review23798
-----------------------------------------------------------
On July 24, 2013, 10:18 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11161/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 10:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't accept offers on the same host/port.
>
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
>
> Review: https://reviews.apache.org/r/11161/
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 279f84e0f0c43ad3cfd9e4442010e706ee3565d9
>
> Diff: https://reviews.apache.org/r/11161/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11161: Don't accept offers on the same host/port.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/#review23798
-----------------------------------------------------------
Did you get any logs to indicate why this was happening in the first place? The comments seem to suggest we were waiting for more data to diagnose this.
- Vinod Kone
On July 24, 2013, 10:18 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11161/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 10:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't accept offers on the same host/port.
>
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
>
> Review: https://reviews.apache.org/r/11161/
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 279f84e0f0c43ad3cfd9e4442010e706ee3565d9
>
> Diff: https://reviews.apache.org/r/11161/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11161: No longer accept offers on the same host/port.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/
-----------------------------------------------------------
(Updated July 30, 2013, 9 p.m.)
Review request for mesos.
Changes
-------
Updated as per Ben's comments.
Summary (updated)
-----------------
No longer accept offers on the same host/port.
Repository: mesos
Description (updated)
-------
No longer accept offers on the same host/port.
We'll try to find a port combination that hasn't already been used to
launch a TaskTracker.
Review: https://reviews.apache.org/r/11161/
Diffs (updated)
-----
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 69d4655a38c6fd24c19918d240727a43cd1c9c92
Diff: https://reviews.apache.org/r/11161/diff/
Testing
-------
Used in production at airbnb.
make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
Thanks,
Brenden Matthews
Re: Review Request 11161: Don't accept offers on the same host/port.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/#review24267
-----------------------------------------------------------
Ship it!
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/11161/#comment48091>
Range is ordered, so there's no need to do this. Were you concerned about that?
If so, how about just adding an assertion or a LOG.fatal, we should better document the Value.Range type in mesos.proto if this part is not clear!
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/11161/#comment48093>
Can you add a comment indicating why this was added? What did you observe? This is indicative of a bug in mesos if we reported a port available that was in use!
s/launched/launched./
- Ben Mahler
On July 25, 2013, 1:42 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11161/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 1:42 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't accept offers on the same host/port.
>
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
>
> Review: https://reviews.apache.org/r/11161/
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 279f84e0f0c43ad3cfd9e4442010e706ee3565d9
>
> Diff: https://reviews.apache.org/r/11161/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11161: Don't accept offers on the same host/port.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/
-----------------------------------------------------------
(Updated July 25, 2013, 1:42 a.m.)
Review request for mesos.
Changes
-------
Add dependency.
Repository: mesos
Description
-------
Don't accept offers on the same host/port.
We'll try to find a port combination that hasn't already been used to
launch a TaskTracker.
Review: https://reviews.apache.org/r/11161/
Diffs
-----
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 279f84e0f0c43ad3cfd9e4442010e706ee3565d9
Diff: https://reviews.apache.org/r/11161/diff/
Testing
-------
Used in production at airbnb.
make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
Thanks,
Brenden Matthews
Re: Review Request 11161: Don't accept offers on the same host/port.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11161/#review23803
-----------------------------------------------------------
Ship it!
Ok. But please add a comment mentioning that you have seen this in the past and its not yet clear why its happening. Maybe a TODO to diagnose/fix it.
- Vinod Kone
On July 24, 2013, 10:18 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11161/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 10:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Don't accept offers on the same host/port.
>
> We'll try to find a port combination that hasn't already been used to
> launch a TaskTracker.
>
> Review: https://reviews.apache.org/r/11161/
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 279f84e0f0c43ad3cfd9e4442010e706ee3565d9
>
> Diff: https://reviews.apache.org/r/11161/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
> make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3
>
>
> Thanks,
>
> Brenden Matthews
>
>