You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mi...@apache.org on 2015/03/10 17:44:09 UTC
[12/14] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34458
moved the unit test where it can be run by 'ant test'. Also,
the main test runner is an Application, rather than a WindowedApplication,
so I changed how uncaught client errors are captured
FLEX-34458 moved the unit test where it can be run by 'ant test'. Also, the main test runner is an Application, rather than a WindowedApplication, so I changed how uncaught client errors are captured to reflect this.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/143a23cd
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/143a23cd
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/143a23cd
Branch: refs/heads/develop
Commit: 143a23cd34fdb22b34f704a356ae1443bc5edf1c
Parents: 939c510
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Mar 10 17:00:34 2015 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Mar 10 17:00:34 2015 +0100
----------------------------------------------------------------------
...icalCollectionViewCursor_FLEX_34458_Tests.as | 126 ++++++++++++++++++
...hicalCollectionViewCursor_FLEX_34458_Test.as | 132 -------------------
2 files changed, 126 insertions(+), 132 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/143a23cd/frameworks/projects/advancedgrids/tests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/tests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Tests.as b/frameworks/projects/advancedgrids/tests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Tests.as
new file mode 100644
index 0000000..963e780
--- /dev/null
+++ b/frameworks/projects/advancedgrids/tests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Tests.as
@@ -0,0 +1,126 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package mx.collections
+{
+ import flash.events.UncaughtErrorEvent;
+
+ import mx.core.FlexGlobals;
+
+ import org.flexunit.asserts.assertEquals;
+ import org.flexunit.asserts.assertNotNull;
+ import org.flexunit.asserts.assertTrue;
+
+ import spark.components.Application;
+
+ public class HierarchicalCollectionViewCursor_FLEX_34458_Tests
+ {
+ private static var _utils:HierarchicalCollectionViewTestUtils = new HierarchicalCollectionViewTestUtils();
+ private static var _noErrorsThrown:Boolean = true;
+ private static var _currentHierarchy:HierarchicalCollectionView;
+ private static var _sut:HierarchicalCollectionViewCursor;
+ private static var _operationCursor:HierarchicalCollectionViewCursor;
+
+ [BeforeClass]
+ public static function setUpBeforeClass():void
+ {
+ if(FlexGlobals.topLevelApplication is Application)
+ (FlexGlobals.topLevelApplication as Application).loaderInfo.uncaughtErrorEvents.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR, onUncaughtClientError);
+ }
+
+ [AfterClass]
+ public static function tearDownAfterClass():void
+ {
+ if(FlexGlobals.topLevelApplication is Application)
+ (FlexGlobals.topLevelApplication as Application).loaderInfo.uncaughtErrorEvents.removeEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR, onUncaughtClientError);
+ }
+
+ [Before]
+ public function setUp():void
+ {
+ _currentHierarchy = _utils.generateOpenHierarchyFromRootListWithAllNodesMethod(_utils.generateHierarchySourceFromString(HIERARCHY_STRING));
+ _sut = _currentHierarchy.createCursor() as HierarchicalCollectionViewCursor;
+ }
+
+ [After]
+ public function tearDown():void
+ {
+ _sut = null;
+ _currentHierarchy = null;
+ _operationCursor = null;
+ }
+
+ [Test]
+ public function testReproduce_FLEX_34458():void
+ {
+ //WHEN
+ //1. Select a specific node
+ _sut.moveToLast();
+ _sut.movePrevious(); //Region(2)->City(3), with currentChildBookmark == CursorBookmark.LAST
+
+ var selectedNode:DataNode = DataNode(_sut.current);
+ assertNotNull(selectedNode);
+ selectedNode.isSelected = true;
+
+ //2. Remove previous region
+ _operationCursor = _currentHierarchy.createCursor() as HierarchicalCollectionViewCursor;
+ _operationCursor.seek(CursorBookmark.FIRST, 3); //Region(2)->City(1)
+ performRemoval(_operationCursor);
+
+ //THEN
+ assertTrue(_noErrorsThrown);
+ assertEquals(selectedNode, _sut.current);
+ }
+
+
+ private static function performRemoval(where:HierarchicalCollectionViewCursor):void
+ {
+ var itemToBeRemoved:DataNode = where.current as DataNode;
+ assertNotNull(itemToBeRemoved);
+
+ var parentOfReplacementLocation:DataNode = _currentHierarchy.getParentItem(itemToBeRemoved) as DataNode;
+ var collectionToChange:ArrayCollection = parentOfReplacementLocation ? parentOfReplacementLocation.children : _utils.getRoot(_currentHierarchy) as ArrayCollection;
+ var removedItemIndex:int = collectionToChange.getItemIndex(itemToBeRemoved);
+ collectionToChange.removeItemAt(removedItemIndex);
+ }
+
+
+
+ private static function onUncaughtClientError(event:UncaughtErrorEvent):void
+ {
+ event.preventDefault();
+ event.stopImmediatePropagation();
+ _noErrorsThrown = false;
+
+ trace("\n FAIL: " + event.error);
+ _utils.printHCollectionView(_currentHierarchy);
+ }
+
+
+ private static const HIERARCHY_STRING:String = (<![CDATA[
+ Region(1)
+ Region(2)
+ Region(2)->City(0)
+ Region(2)->City(1)
+ Region(2)->City(2)
+ Region(2)->City(3)
+ Region(3)
+ ]]>).toString();
+ }
+}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/143a23cd/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Test.as
----------------------------------------------------------------------
diff --git a/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Test.as b/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Test.as
deleted file mode 100644
index 34f0b2f..0000000
--- a/frameworks/tests/unitTests/mx/collections/HierarchicalCollectionViewCursor_FLEX_34458_Test.as
+++ /dev/null
@@ -1,132 +0,0 @@
-////////////////////////////////////////////////////////////////////////////////
-//
-// Licensed to the Apache Software Foundation (ASF) under one or more
-// contributor license agreements. See the NOTICE file distributed with
-// this work for additional information regarding copyright ownership.
-// The ASF licenses this file to You under the Apache License, Version 2.0
-// (the "License"); you may not use this file except in compliance with
-// the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-////////////////////////////////////////////////////////////////////////////////
-
-package mx.collections
-{
-import flash.events.UncaughtErrorEvent;
-
-import mx.collections.ArrayCollection;
-import mx.collections.CursorBookmark;
-import mx.collections.HierarchicalCollectionView;
-import mx.collections.HierarchicalCollectionViewCursor;
-import mx.core.FlexGlobals;
-
- import org.flexunit.asserts.assertEquals;
-
- import org.flexunit.asserts.assertNotNull;
-import org.flexunit.asserts.assertTrue;
-import org.flexunit.runners.Parameterized;
-
-import spark.components.WindowedApplication;
-
-public class HierarchicalCollectionViewCursor_FLEX_34458_Test
- {
- private static var _utils:HierarchicalCollectionViewTestUtils = new HierarchicalCollectionViewTestUtils();
- private static var _noErrorsThrown:Boolean = true;
- private static var _currentHierarchy:HierarchicalCollectionView;
- private static var _sut:HierarchicalCollectionViewCursor;
- private static var _operationCursor:HierarchicalCollectionViewCursor;
-
- [BeforeClass]
- public static function setUpBeforeClass():void
- {
- if(FlexGlobals.topLevelApplication is WindowedApplication)
- (FlexGlobals.topLevelApplication as WindowedApplication).loaderInfo.uncaughtErrorEvents.addEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR, onUncaughtClientError);
- }
-
- [AfterClass]
- public static function tearDownAfterClass():void
- {
- if(FlexGlobals.topLevelApplication is WindowedApplication)
- (FlexGlobals.topLevelApplication as WindowedApplication).loaderInfo.uncaughtErrorEvents.removeEventListener(UncaughtErrorEvent.UNCAUGHT_ERROR, onUncaughtClientError);
- }
-
- [Before]
- public function setUp():void
- {
- _currentHierarchy = _utils.generateOpenHierarchyFromRootListWithAllNodesMethod(_utils.generateHierarchySourceFromString(HIERARCHY_STRING));
- _sut = _currentHierarchy.createCursor() as HierarchicalCollectionViewCursor;
- }
-
- [After]
- public function tearDown():void
- {
- _sut = null;
- _currentHierarchy = null;
- _operationCursor = null;
- }
-
- [Test]
- public function testReproduce_FLEX_34458():void
- {
- //WHEN
- //1. Select a specific node
- _sut.moveToLast();
- _sut.movePrevious(); //Region(2)->City(3), with currentChildBookmark == CursorBookmark.LAST
-
- var selectedNode:DataNode = DataNode(_sut.current);
- assertNotNull(selectedNode);
- selectedNode.isSelected = true;
-
- //2. Remove previous region
- _operationCursor = _currentHierarchy.createCursor() as HierarchicalCollectionViewCursor;
- _operationCursor.seek(CursorBookmark.FIRST, 3); //Region(2)->City(1)
- performRemoval(_operationCursor);
-
- //THEN
- assertTrue(_noErrorsThrown);
- assertEquals(selectedNode, _sut.current);
- }
-
-
- private static function performRemoval(where:HierarchicalCollectionViewCursor):void
- {
- var itemToBeRemoved:DataNode = where.current as DataNode;
- assertNotNull(itemToBeRemoved);
-
- var parentOfReplacementLocation:DataNode = _currentHierarchy.getParentItem(itemToBeRemoved) as DataNode;
- var collectionToChange:ArrayCollection = parentOfReplacementLocation ? parentOfReplacementLocation.children : _utils.getRoot(_currentHierarchy) as ArrayCollection;
- var removedItemIndex:int = collectionToChange.getItemIndex(itemToBeRemoved);
- collectionToChange.removeItemAt(removedItemIndex);
- }
-
-
-
- private static function onUncaughtClientError(event:UncaughtErrorEvent):void
- {
- event.preventDefault();
- event.stopImmediatePropagation();
- _noErrorsThrown = false;
-
- trace("\n FAIL: " + event.error);
- _utils.printHCollectionView(_currentHierarchy);
- }
-
-
- private static const HIERARCHY_STRING:String = (<![CDATA[
- Region(1)
- Region(2)
- Region(2)->City(0)
- Region(2)->City(1)
- Region(2)->City(2)
- Region(2)->City(3)
- Region(3)
- ]]>).toString();
- }
-}
\ No newline at end of file