You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/20 11:26:29 UTC
[GitHub] [airflow] blcksrx opened a new pull request #8918: Impala hook implention
blcksrx opened a new pull request #8918:
URL: https://github.com/apache/airflow/pull/8918
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists #8916
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-660112766
No Problem. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-659889219
That's an interesting one.
It looks like there is a conflict of dependencies between Impala and Hive (because of incompatible versions of thrift used - the root cause is org.apache.hive.service.rpc.thrift.TCLIService ). Impyla dynamically replaces TCLIService with an incompatible version.
The issue is described here: https://github.com/cloudera/impyla/issues/277
And there is a fix in impyla for that: https://github.com/cloudera/impyla/commit/0284cc0850a1acf53507ba1366022fc36e6df517
It was merged 12th of June, but the latest release of Impyla was done 2nd May. I've asked what are the plans for Impyla to release a new version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-659890063
Sorry for that :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-710780068
@blcksrx impyla v0.16.3 was released 10 days ago and it includes the commit @potiuk was referring to.
Can this PR revisited due to the new version release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-647280779
Sure! I will do it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-647178474
Hello @blcksrx -> i will happily review it but I think you need to rebase and fix some of the static checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-710780274
> @blcksrx impyla v0.16.3 was released 10 days ago and it includes the commit @potiuk was referring to.
> Can this PR revisited due to the new version release?
Yes of course. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-659627891
@potiuk I fixed the static checks! but currently, there are issues related to `pyhive`:
```
AttributeError: module 'pyhive' has no attribute 'hive'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-659889798
I guess we will have to wait with the merge unti impyla releases next version I am afraid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] closed pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #8918:
URL: https://github.com/apache/airflow/pull/8918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #8918: Impala hook implention
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #8918:
URL: https://github.com/apache/airflow/pull/8918#issuecomment-683799844
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org