You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/03/08 17:06:45 UTC
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6316
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
IMPALA-5044: test infra: remove backports.tempfile
backports.tempfile is not compatible with Python 2.6, so if Python 2.6
is the Python used for end-to-end tests, this test uncondtionally fails.
Moreover, Py.test provides a builtin tmpdir fixture with equivalent
functionality. Remove the requirement and port tests using
backports.tempfile.TemporaryDirectory to use tmpdir.
Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
---
M infra/python/deps/requirements.txt
M tests/query_test/test_insert_parquet.py
2 files changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/6316/1
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
Patch Set 2: Code-Review+2
Thank you for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/360/
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
Patch Set 3: Code-Review+2
[fixed a typo in the commit message]
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6316
to look at the new patch set (#3).
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
IMPALA-5044: test infra: remove backports.tempfile
backports.tempfile is not compatible with Python 2.6, so if Python 2.6
is the Python used for end-to-end tests, this test unconditionally
fails. Moreover, Py.test provides a builtin tmpdir fixture with
equivalent functionality. Remove the requirement and port tests using
backports.tempfile.TemporaryDirectory to use tmpdir.
Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
---
M infra/python/deps/requirements.txt
M tests/query_test/test_insert_parquet.py
2 files changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/6316/3
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
Patch Set 1:
I think this patch should work. It's untested, but I will test it on Python 2.6 in a moment and report back.
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
IMPALA-5044: test infra: remove backports.tempfile
backports.tempfile is not compatible with Python 2.6, so if Python 2.6
is the Python used for end-to-end tests, this test unconditionally
fails. Moreover, Py.test provides a builtin tmpdir fixture with
equivalent functionality. Remove the requirement and port tests using
backports.tempfile.TemporaryDirectory to use tmpdir.
Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Reviewed-on: http://gerrit.cloudera.org:8080/6316
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M infra/python/deps/requirements.txt
M tests/query_test/test_insert_parquet.py
2 files changed, 7 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has uploaded a new patch set (#2).
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
IMPALA-5044: test infra: remove backports.tempfile
backports.tempfile is not compatible with Python 2.6, so if Python 2.6
is the Python used for end-to-end tests, this test uncondtionally fails.
Moreover, Py.test provides a builtin tmpdir fixture with equivalent
functionality. Remove the requirement and port tests using
backports.tempfile.TemporaryDirectory to use tmpdir.
Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
---
M infra/python/deps/requirements.txt
M tests/query_test/test_insert_parquet.py
2 files changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/6316/2
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5044: test infra: remove backports.tempfile
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5044: test infra: remove backports.tempfile
......................................................................
Patch Set 3:
> I think this patch should work. It's untested, but I will test it
> on Python 2.6 in a moment and report back.
I tested patch set 2 on Python 6, and this particular test passed on it.
--
To view, visit http://gerrit.cloudera.org:8080/6316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887b62eb1b3425fc8fd62562e28f0c17cb261f6d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No