[GitHub] [trafficcontrol] rob05c commented on a change in pull request #6052: update print statements in t3c to use go logger library

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #6052:
URL: https://github.com/apache/trafficcontrol/pull/6052#discussion_r675163955



##########
File path: cache-config/t3c-generate/plugin/plugin.go
##########
@@ -59,7 +58,7 @@ type Plugins interface {
 func AddPlugin(priority uint64, funcs Funcs) {
 	_, filename, _, ok := runtime.Caller(1)
 	if !ok {
-		fmt.Println(time.Now().Format(time.RFC3339Nano) + " Error plugin.AddPlugin: runtime.Caller failed, can't get plugin names") // print, because this is called in init, loggers don't exist yet
+		log.Errorln(time.Now().Format(time.RFC3339Nano) + " Error plugin.AddPlugin: runtime.Caller failed, can't get plugin names")

Review comment:
       This needs to still be a Print, because like the comment said, the loggers haven't been initialized yet




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org