You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/10/26 11:05:22 UTC
[GitHub] [incubator-eventmesh] AhahaGe opened a new pull request #571: Contributing guide remove import check style step
AhahaGe opened a new pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571
Fixes ISSUE #569.
Motivation
I can't import eventMesh checkStyle file into idea. It shows error message.
And it's also not mandatory for developer, and it's for github cicd.
So We can remove it in Contributing guide.
Modifications
Edit both CONTRIBUTING.md and CONTRIBUTING>zh-CN.md file remove import code style step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe closed pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
AhahaGe closed pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on a change in pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on a change in pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#discussion_r736415762
##########
File path: CONTRIBUTING.md
##########
@@ -3,21 +3,6 @@
Welcome to EventMesh! This document is a guideline about how to contribute to EventMesh. If you find something incorrect
or missing, please leave comments / suggestions.
-## Before you get started
-
-### Setting up your development environment
Review comment:
@AhahaGe suggest not removed, but add some comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe commented on a change in pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
AhahaGe commented on a change in pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#discussion_r736418518
##########
File path: CONTRIBUTING.md
##########
@@ -3,21 +3,6 @@
Welcome to EventMesh! This document is a guideline about how to contribute to EventMesh. If you find something incorrect
or missing, please leave comments / suggestions.
-## Before you get started
-
-### Setting up your development environment
Review comment:
Because with ide, if we don't import it, we can't check code style. And In some other part of file, we have noticed that. So I suggest to delete it.
Code review
All code should be well reviewed by one or more committers. Some principles:
Readability: Important code should be well-documented. Comply with our code style.
Elegance: New functions, classes or components should be well-designed.
Testability: Important code should be well-tested (high unit test coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe commented on a change in pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
AhahaGe commented on a change in pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#discussion_r736418518
##########
File path: CONTRIBUTING.md
##########
@@ -3,21 +3,6 @@
Welcome to EventMesh! This document is a guideline about how to contribute to EventMesh. If you find something incorrect
or missing, please leave comments / suggestions.
-## Before you get started
-
-### Setting up your development environment
Review comment:
Because with ide, if we don't import it, we can't check code style. And In some other part of this file, we have noticed that. So I suggest to delete it.
Code review
All code should be well reviewed by one or more committers. Some principles:
Readability: Important code should be well-documented. Comply with our code style.
Elegance: New functions, classes or components should be well-designed.
Testability: Important code should be well-tested (high unit test coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe commented on pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
AhahaGe commented on pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#issuecomment-951834504
> This is mandatory for contributor, if contributors hope to contribute code to EventMesh, they need to follow the code style rule in EventMesh. You can't remove this.
>
> If you have suggestions about the rules defined checkstyle you can discuss in #444, or send mail to [dev@eventmesh.apache.org](mailto:dev@eventmesh.apache.org).
Because with ide, if we don't import it, we can't check code style. And In some other part of this file, we have noticed that. So I suggest to delete the step of Setting up your development environment.
If we can supply a checkfile which can be loaded success, that's ok
Code review
All code should be well reviewed by one or more committers. Some principles:
Readability: Important code should be well-documented. Comply with our code style.
Elegance: New functions, classes or components should be well-designed.
Testability: Important code should be well-tested (high unit test coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe edited a comment on pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
AhahaGe edited a comment on pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#issuecomment-951834504
> This is mandatory for contributor, if contributors hope to contribute code to EventMesh, they need to follow the code style rule in EventMesh. You can't remove this.
>
> If you have suggestions about the rules defined checkstyle you can discuss in #444, or send mail to [dev@eventmesh.apache.org](mailto:dev@eventmesh.apache.org).
Because with ide, if we don't import it, we can't check code style. And In some other part of this file, we have noticed that. So I suggest to delete the step of Setting up your development environment.
If we can supply a checkfile which can be loaded success, that's ok.
Code review
All code should be well reviewed by one or more committers. Some principles:
Readability: Important code should be well-documented. Comply with our code style.
Elegance: New functions, classes or components should be well-designed.
Testability: Important code should be well-tested (high unit test coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#issuecomment-951843693
> > This is mandatory for contributor, if contributors hope to contribute code to EventMesh, they need to follow the code style rule in EventMesh. You can't remove this.
> > If you have suggestions about the rules defined checkstyle you can discuss in #444, or send mail to [dev@eventmesh.apache.org](mailto:dev@eventmesh.apache.org).
>
> Because with ide, if we don't import it, we can't check code style. And In some other part of this file, we have noticed that. So I suggest to delete the step of Setting up your development environment. If we can supply a checkfile which can be loaded success, that's ok.
>
> Code review All code should be well reviewed by one or more committers. Some principles:
>
> Readability: Important code should be well-documented. Comply with our code style. Elegance: New functions, classes or components should be well-designed. Testability: Important code should be well-tested (high unit test coverage).
This file can be loaded successful, if you follow the step describe in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #571: Contributing guide remove import check style step
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #571:
URL: https://github.com/apache/incubator-eventmesh/pull/571#discussion_r736423399
##########
File path: CONTRIBUTING.md
##########
@@ -3,21 +3,6 @@
Welcome to EventMesh! This document is a guideline about how to contribute to EventMesh. If you find something incorrect
or missing, please leave comments / suggestions.
-## Before you get started
-
-### Setting up your development environment
Review comment:
Not every one has set the same code style in their IDE, right? So each time they submit code there are maybe a lot of formatting changes involed, This file is to help the contributor to format their code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org