[jira] [Commented] (TEZ-2583) Allow RecoveryService Pluggable

["Rajesh Balamohan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692866#comment-14692866 ] 

Rajesh Balamohan commented on TEZ-2583:
---------------------------------------

- Would SimpleRecoveryEventHook throw NPE if SIMPLE_SHUTDOWN_CONDITION is not set for any reason?.
- TezExampleBase.getAppId should check for (tezClientInternal != null)?
- Should RecoveryParser.readRecoveryEvents close the stream finally? Might want to consider adding Preconditions checks appId and tezConf?
- Patch needs to be rebased (TaskAttemptFinishedEvent/TaskAttemptStartedEvent) post TEZ-2647?
- Should the tests cover Timinig.PRE case as well?
- import reordering in all files are unintensional?
- In TestRecovery, generateOrderedWordCountInput might be called once instead of getting created in every test.
- Remove unwanted vars in TestRecovery (e.g eventMetaDataV2, taskSpec)

> Allow RecoveryService Pluggable 
> --------------------------------
>
>                 Key: TEZ-2583
>                 URL: https://issues.apache.org/jira/browse/TEZ-2583
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2583-1.patch, TEZ-2583-2.patch
>
>
> RecoveryService is the component to write recovery logs. The purpose of allowing RecoveryService Pluggable is for recovery system test. We need to control when to shutdown AM in the pluggable RecoveryService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)