You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "absolute8511 (via GitHub)" <gi...@apache.org> on 2023/05/23 13:32:53 UTC
[GitHub] [rocketmq] absolute8511 opened a new issue, #6800: [Bug] isEnableBatchPush can not be changed since the setter name is wrong
absolute8511 opened a new issue, #6800:
URL: https://github.com/apache/rocketmq/issues/6800
### Before Creating the Bug Report
- [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions).
- [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate.
- [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
### Runtime platform environment
Linux
### RocketMQ version
4.9.x
### JDK Version
_No response_
### Describe the Bug
isEnableBatchPush can not be changed since the setter name is wrong
### Steps to Reproduce
1. add `isEnableBatchPush=true` in the broker.properties config
2. use `enableDLegerCommitLog=true`
3. saw batch push is not enabled in dledger mode and the var isEnableBatchPush in MessageStoreConfig still false
using test to reproducer
```Java
@Test
public void testBrokerControllerConfigInit() throws Exception {
Properties properties = new Properties();
properties.setProperty("isEnableBatchPush", "true");
MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
MixAll.properties2Object(properties, messageStoreConfig);
assertThat(messageStoreConfig.isEnableBatchPush()).isTrue();
}
```
### What Did You Expect to See?
isEnableBatchPush should be changed after set `isEnableBatchPush=true` in the broker.properties config
### What Did You See Instead?
isEnableBatchPush did not change in the MessageStoreConfig
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on issue #6800: [Bug] isEnableBatchPush can not be changed since the setter name is wrong
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on issue #6800:
URL: https://github.com/apache/rocketmq/issues/6800#issuecomment-1562569975
Actually, set `enableBatchPush` as true can work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #6800: [Bug] isEnableBatchPush can not be changed since the setter name is wrong
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin closed issue #6800: [Bug] isEnableBatchPush can not be changed since the setter name is wrong
URL: https://github.com/apache/rocketmq/issues/6800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org