[GitHub] [mesos] lava commented on a change in pull request #341: Remove unnecessary logging.

[GitBox <gi...@apache.org>]

lava commented on a change in pull request #341: Remove unnecessary logging.
URL: https://github.com/apache/mesos/pull/341#discussion_r313886115
 
 

 ##########
 File path: src/slave/slave.cpp
 ##########
 @@ -7157,11 +7157,6 @@ void Slave::_checkDiskUsage(const Future<double>& usage)
     LOG(ERROR) << "Failed to get disk usage: "
                << (usage.isFailed() ? usage.failure() : "future discarded");
   } else {
-    executorDirectoryMaxAllowedAge = age(usage.get());
 
 Review comment:
   Here `executorDirectoryMaxAllowedAge` is actually a member variable of `Slave` that is used for generating the value of the metric, so removing the assignment will probably break this. (Imho this is also a fault in our C++ style guide, having no visual indication of member variables makes it too easy to make this kind of mistake)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services