You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kalle Olavi Niemitalo <ko...@iki.fi> on 2005/10/15 00:05:46 UTC

Re: [PATCH] psvn: Fix bogus comparisons of buffers to strings.

Stefan Reichör <st...@xsteve.at> writes:

> I have applied that patch now.

While merging psvn.el changes from trunk to a local branch,
I noticed that you didn't apply all of the patch I posted.
I had posted this change:

>>  (defun svn-status-show-process-buffer-internal (&optional scroll-to-top)
>> -  (when (eq (current-buffer) "`svn-status-buffer-name'")
>> +  (when (string= (buffer-name) svn-status-buffer-name)
>>      (delete-other-windows))

You applied this in r15969:

 (defun svn-status-show-process-buffer-internal (&optional scroll-to-top)
-  (when (eq (current-buffer) "`svn-status-buffer-name'")
+  (when (eq (current-buffer) svn-status-buffer-name)
     (delete-other-windows))

This comparison will always return false.
I'm assuming that was inadvertent, so I'll change it soon.