You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2020/12/07 18:00:27 UTC
[tomcat] branch 9.0.x updated: Fix IDE warning
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new dcf2044 Fix IDE warning
dcf2044 is described below
commit dcf2044bd4f653154cb60218a3f3667673f746bf
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Dec 2 14:21:04 2020 +0000
Fix IDE warning
---
java/javax/servlet/http/Cookie.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/javax/servlet/http/Cookie.java b/java/javax/servlet/http/Cookie.java
index e50bebe..bc2dd83 100644
--- a/java/javax/servlet/http/Cookie.java
+++ b/java/javax/servlet/http/Cookie.java
@@ -74,7 +74,7 @@ public class Cookie implements Cloneable, Serializable {
} else {
strictServletCompliance = AccessController.doPrivileged(
(PrivilegedAction<Boolean>) () -> Boolean.valueOf(System.getProperty(
- "org.apache.catalina.STRICT_SERVLET_COMPLIANCE")));
+ "org.apache.catalina.STRICT_SERVLET_COMPLIANCE"))).booleanValue();
propStrictNaming = AccessController.doPrivileged(
(PrivilegedAction<String>) () -> System.getProperty(
"org.apache.tomcat.util.http.ServerCookie.STRICT_NAMING"));
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 9.0.x updated: Fix IDE warning
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 07/12/2020 à 19:00, markt@apache.org a écrit :
> commit dcf2044bd4f653154cb60218a3f3667673f746bf
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Wed Dec 2 14:21:04 2020 +0000
>
> Fix IDE warning
> ---
> java/javax/servlet/http/Cookie.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/java/javax/servlet/http/Cookie.java b/java/javax/servlet/http/Cookie.java
> index e50bebe..bc2dd83 100644
> --- a/java/javax/servlet/http/Cookie.java
> +++ b/java/javax/servlet/http/Cookie.java
> @@ -74,7 +74,7 @@ public class Cookie implements Cloneable, Serializable {
> } else {
> strictServletCompliance = AccessController.doPrivileged(
> (PrivilegedAction<Boolean>) () -> Boolean.valueOf(System.getProperty(
> - "org.apache.catalina.STRICT_SERVLET_COMPLIANCE")));
> + "org.apache.catalina.STRICT_SERVLET_COMPLIANCE"))).booleanValue();
> propStrictNaming = AccessController.doPrivileged(
> (PrivilegedAction<String>) () -> System.getProperty(
> "org.apache.tomcat.util.http.ServerCookie.STRICT_NAMING"));
My IDE (IntelliJ 2020.3) gives the opposite warning and suggests using
auto-boxing instead of explicit boxing/unboxing. Should I avoid using
auto-boxing in Tomcat?
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org