You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2017/12/11 16:55:34 UTC

[GitHub] rhtyd commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

rhtyd commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#discussion_r156132782
 
 

 ##########
 File path: test/integration/smoke/test_deploy_vm_root_resize.py
 ##########
 @@ -219,30 +220,34 @@ def test_00_deploy_vm_root_resize(self):
         """
 
         newrootsize = (self.template.size >> 30) + 2
-        if(self.hypervisor.lower() == 'kvm' or self.hypervisor.lower() ==
-            'xenserver'or self.hypervisor.lower() == 'vmware'  ):
+        if (self.hypervisor.lower() == 'kvm' or self.hypervisor.lower() == 'xenserver'
 
 Review comment:
   This could have been rewritten as `obj in array:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services