You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wjones127 (via GitHub)" <gi...@apache.org> on 2023/04/28 18:04:50 UTC

[GitHub] [arrow] wjones127 commented on a diff in pull request #35242: GH-35171: [C++][Parquet] Implement CRC for data page v2

wjones127 commented on code in PR #35242:
URL: https://github.com/apache/arrow/pull/35242#discussion_r1180685776


##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -4092,7 +4092,7 @@ TEST_P(TestArrowWriteDictionary, Statistics) {
       {{"b", "a"}, {"b", "a"}}, {{"c", "c"}, {"c", "c"}}, {{"d", "a"}, {"d", "a"}}};
   const std::vector<std::vector<std::vector<bool>>> expected_has_min_max_by_page = {
       {{true, true}, {true, true}},
-      {{true, true}, {true, true}},
+      {{true, false}, {true, false}},

Review Comment:
   Why did this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org