You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shwetha GS <ss...@hortonworks.com> on 2016/11/07 10:21:37 UTC

Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53525/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1246
    https://issues.apache.org/jira/browse/ATLAS-1246


Repository: atlas


Description
-------

1. Changed scala version to 2.11
2. Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan


Diffs
-----

  addons/falcon-bridge/pom.xml de3e810 
  addons/hive-bridge/pom.xml 884791d 
  addons/sqoop-bridge/pom.xml 9ac411e 
  addons/storm-bridge/pom.xml fcb6e01 
  authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe81598 
  common/pom.xml e3b6465 
  graphdb/common/pom.xml 43d51f6 
  graphdb/titan0/pom.xml ca8c0fb 
  intg/pom.xml b29a0c2 
  notification/pom.xml 90d84ec 
  pom.xml a6fa7fb 
  repository/pom.xml af5d4a1 
  repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c3fd72b 
  shaded/hbase-client-shaded/pom.xml PRE-CREATION 
  shaded/hbase-server-shaded/pom.xml PRE-CREATION 
  typesystem/pom.xml 28c077d 
  webapp/pom.xml 6dbd484 

Diff: https://reviews.apache.org/r/53525/diff/


Testing
-------

UTs and end to end test external hbase and solr


Thanks,

Shwetha GS


Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53525/#review155943
-----------------------------------------------------------


Ship it!




Ship It!

- Suma Shivaprasad


On Nov. 15, 2016, 8:17 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53525/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 8:17 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1246
>     https://issues.apache.org/jira/browse/ATLAS-1246
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. Changed scala version to 2.11
> 2. Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/pom.xml 96743e7 
>   addons/hive-bridge/pom.xml 7ab47f1 
>   addons/sqoop-bridge/pom.xml e71d64a 
>   addons/storm-bridge/pom.xml 6be55b4 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe81598 
>   common/pom.xml e3b6465 
>   graphdb/common/pom.xml 43d51f6 
>   graphdb/titan0/pom.xml ca8c0fb 
>   intg/pom.xml b29a0c2 
>   notification/pom.xml 90d84ec 
>   pom.xml 2044bfd 
>   repository/pom.xml af5d4a1 
>   repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c3fd72b 
>   shaded/hbase-client-shaded/pom.xml PRE-CREATION 
>   shaded/hbase-server-shaded/pom.xml PRE-CREATION 
>   typesystem/pom.xml 28c077d 
>   webapp/pom.xml b9e1111 
> 
> Diff: https://reviews.apache.org/r/53525/diff/
> 
> 
> Testing
> -------
> 
> UTs and end to end test external hbase and solr
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53525/
-----------------------------------------------------------

(Updated Nov. 15, 2016, 8:17 a.m.)


Review request for atlas.


Changes
-------

Addressed review comment


Bugs: ATLAS-1246
    https://issues.apache.org/jira/browse/ATLAS-1246


Repository: atlas


Description
-------

1. Changed scala version to 2.11
2. Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan


Diffs (updated)
-----

  addons/falcon-bridge/pom.xml 96743e7 
  addons/hive-bridge/pom.xml 7ab47f1 
  addons/sqoop-bridge/pom.xml e71d64a 
  addons/storm-bridge/pom.xml 6be55b4 
  authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe81598 
  common/pom.xml e3b6465 
  graphdb/common/pom.xml 43d51f6 
  graphdb/titan0/pom.xml ca8c0fb 
  intg/pom.xml b29a0c2 
  notification/pom.xml 90d84ec 
  pom.xml 2044bfd 
  repository/pom.xml af5d4a1 
  repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c3fd72b 
  shaded/hbase-client-shaded/pom.xml PRE-CREATION 
  shaded/hbase-server-shaded/pom.xml PRE-CREATION 
  typesystem/pom.xml 28c077d 
  webapp/pom.xml b9e1111 

Diff: https://reviews.apache.org/r/53525/diff/


Testing
-------

UTs and end to end test external hbase and solr


Thanks,

Shwetha GS


Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53525/#review155835
-----------------------------------------------------------




shaded/hbase-client-shaded/pom.xml (line 64)
<https://reviews.apache.org/r/53525/#comment225930>

    pls add a comment for the reasons for shading which was mentioned aboev 
    
    Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan


- Suma Shivaprasad


On Nov. 14, 2016, 9:01 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53525/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 9:01 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1246
>     https://issues.apache.org/jira/browse/ATLAS-1246
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. Changed scala version to 2.11
> 2. Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/pom.xml 96743e7 
>   addons/hive-bridge/pom.xml 7ab47f1 
>   addons/sqoop-bridge/pom.xml e71d64a 
>   addons/storm-bridge/pom.xml 6be55b4 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe81598 
>   common/pom.xml e3b6465 
>   graphdb/common/pom.xml 43d51f6 
>   graphdb/titan0/pom.xml ca8c0fb 
>   intg/pom.xml b29a0c2 
>   notification/pom.xml 90d84ec 
>   pom.xml 2044bfd 
>   repository/pom.xml af5d4a1 
>   repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c3fd72b 
>   shaded/hbase-client-shaded/pom.xml PRE-CREATION 
>   shaded/hbase-server-shaded/pom.xml PRE-CREATION 
>   typesystem/pom.xml 28c077d 
>   webapp/pom.xml b9e1111 
> 
> Diff: https://reviews.apache.org/r/53525/diff/
> 
> 
> Testing
> -------
> 
> UTs and end to end test external hbase and solr
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>


Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53525/
-----------------------------------------------------------

(Updated Nov. 14, 2016, 9:01 a.m.)


Review request for atlas.


Changes
-------

mvn 3.3.x includes hbase and titan jars even though they are shaded and used as uber jar. So, excluding them explicitly in maven war plugin. I have verified this on the stack


Bugs: ATLAS-1246
    https://issues.apache.org/jira/browse/ATLAS-1246


Repository: atlas


Description
-------

1. Changed scala version to 2.11
2. Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan


Diffs (updated)
-----

  addons/falcon-bridge/pom.xml 96743e7 
  addons/hive-bridge/pom.xml 7ab47f1 
  addons/sqoop-bridge/pom.xml e71d64a 
  addons/storm-bridge/pom.xml 6be55b4 
  authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe81598 
  common/pom.xml e3b6465 
  graphdb/common/pom.xml 43d51f6 
  graphdb/titan0/pom.xml ca8c0fb 
  intg/pom.xml b29a0c2 
  notification/pom.xml 90d84ec 
  pom.xml 2044bfd 
  repository/pom.xml af5d4a1 
  repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c3fd72b 
  shaded/hbase-client-shaded/pom.xml PRE-CREATION 
  shaded/hbase-server-shaded/pom.xml PRE-CREATION 
  typesystem/pom.xml 28c077d 
  webapp/pom.xml b9e1111 

Diff: https://reviews.apache.org/r/53525/diff/


Testing
-------

UTs and end to end test external hbase and solr


Thanks,

Shwetha GS


Re: Review Request 53525: ATLAS-1246 Upgrade versions of dependencies

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53525/#review155176
-----------------------------------------------------------


Ship it!




Ship It!

- Suma Shivaprasad


On Nov. 7, 2016, 10:21 a.m., Shwetha GS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53525/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 10:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1246
>     https://issues.apache.org/jira/browse/ATLAS-1246
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. Changed scala version to 2.11
> 2. Changed guava version to 18.0. hbase and titan doesn't work with guava 18. In general, when hbase and titan versions are changed using properties, the guava versions that hbase, titan and atlas require may be incompatible and will fail at runtime. So, shaded the guava dependencies in hbase and titan
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/pom.xml de3e810 
>   addons/hive-bridge/pom.xml 884791d 
>   addons/sqoop-bridge/pom.xml 9ac411e 
>   addons/storm-bridge/pom.xml fcb6e01 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fe81598 
>   common/pom.xml e3b6465 
>   graphdb/common/pom.xml 43d51f6 
>   graphdb/titan0/pom.xml ca8c0fb 
>   intg/pom.xml b29a0c2 
>   notification/pom.xml 90d84ec 
>   pom.xml a6fa7fb 
>   repository/pom.xml af5d4a1 
>   repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java c3fd72b 
>   shaded/hbase-client-shaded/pom.xml PRE-CREATION 
>   shaded/hbase-server-shaded/pom.xml PRE-CREATION 
>   typesystem/pom.xml 28c077d 
>   webapp/pom.xml 6dbd484 
> 
> Diff: https://reviews.apache.org/r/53525/diff/
> 
> 
> Testing
> -------
> 
> UTs and end to end test external hbase and solr
> 
> 
> Thanks,
> 
> Shwetha GS
> 
>