You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "dididy (via GitHub)" <gi...@apache.org> on 2025/09/04 15:32:32 UTC
[PR] [ZEPPELIN-6138] Add .nvmrc to set node v16.20.2 for Zeppelin client [zeppelin]
dididy opened a new pull request, #5068:
URL: https://github.com/apache/zeppelin/pull/5068
### What is this PR for?
Using a `.nvmrc` file allows people using `nvm` to easily specify and switch to the desired Node version. In my work, I often use different Node versions for Zeppelin and other projects, and switching between them every time can be cumbersome. Setting up a `.nvmrc` would automate this process, making it much more convenient. It would also allow `nvm` users to not worry about the Node version, thereby reducing unnecessary overhead.
https://github.com/apache/superset/blob/master/docs/.nvmrc
I looked at other Apache projects and found that Superset already uses a `.nvmrc` file. Therefore, it would be beneficial to apply the same to Zeppelin. And in this PR, I pinned Node to version **16.20.2** for both **zeppelin-web** and **zeppelin-web-angular**, the latest release of Node 16, using `.nvmrc`.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
* [[ZEPPELIN-6318](https://issues.apache.org/jira/browse/ZEPPELIN-6318)]
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Add .nvmrc to set node v16.20.2 for Zeppelin client [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5068:
URL: https://github.com/apache/zeppelin/pull/5068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Add .nvmrc to set node v16.20.2 for Zeppelin client [zeppelin]
Posted by "ParkGyeongTae (via GitHub)" <gi...@apache.org>.
ParkGyeongTae commented on code in PR #5068:
URL: https://github.com/apache/zeppelin/pull/5068#discussion_r2323713610
##########
zeppelin-web-angular/.nvrmc:
##########
@@ -0,0 +1 @@
+16.20.2
Review Comment:
Please add the Apache license header to this part.
##########
zeppelin-web/.nvrmc:
##########
@@ -0,0 +1 @@
+16.20.2
Review Comment:
Please add the Apache license header here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Add .nvmrc to set node v16.20.2 for Zeppelin client [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5068:
URL: https://github.com/apache/zeppelin/pull/5068#issuecomment-3261444501
Merged into master and branch-0.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Add .nvmrc to set node v16.20.2 for Zeppelin client [zeppelin]
Posted by "ParkGyeongTae (via GitHub)" <gi...@apache.org>.
ParkGyeongTae commented on code in PR #5068:
URL: https://github.com/apache/zeppelin/pull/5068#discussion_r2323713367
##########
zeppelin-web-angular/.nvrmc:
##########
@@ -0,0 +1 @@
+16.20.2
Review Comment:
Please add the Apache license header to this part.
##########
zeppelin-web-angular/.nvrmc:
##########
@@ -0,0 +1 @@
+16.20.2
Review Comment:
Please add the Apache license header to this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org