You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by davidcavazos <gi...@git.apache.org> on 2017/08/17 21:37:24 UTC

[GitHub] beam pull request #3728: Combine globally

GitHub user davidcavazos opened a pull request:

    https://github.com/apache/beam/pull/3728

    Combine globally

    Hi @aaltay,
    
    This just gives a more convenient way to call global combiners when needed as views or without defaults.
    
    e.g.
    ``beam.combiners.Mean.Globally(as_view=True)``
    ``beam.combiners.Mean.Globally(has_defaults=False)``
    
    instead of:
    
    ``beam.CombineGlobally(beam.combiners.MeanCombineFn()).as_singleton_view()``
    ``beam.CombineGlobally(beam.combiners.MeanCombineFn()).without_defaults()``

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidcavazos/beam combine_globally

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3728
    
----
commit b9ca9ff249e5f45788de1bba8fab425306e7290d
Author: David Cavazos <dc...@google.com>
Date:   2017-08-17T21:17:37Z

    Fixed indentation error on pydoc

commit 692e00a064e38575fe4c49e9c7ac209fc38a9c6a
Author: David Cavazos <dc...@google.com>
Date:   2017-08-17T21:28:05Z

    Add 'as_view' and 'has_defaults' to combiners that use CombineGlobally

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3728: Combine globally

Posted by davidcavazos <gi...@git.apache.org>.
Github user davidcavazos closed the pull request at:

    https://github.com/apache/beam/pull/3728


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---