You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/30 19:04:11 UTC
[GitHub] [kafka] jsancio opened a new pull request #11556: MINOR: Pass along compression type to snapshot writer
jsancio opened a new pull request #11556:
URL: https://github.com/apache/kafka/pull/11556
Make sure that the compression type is passed along to the
RecordsSnapshotWriter constructor when creating the snapshot writer
using the static createWithHeader method.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #11556: MINOR: Pass along compression type to snapshot writer
Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11556:
URL: https://github.com/apache/kafka/pull/11556#issuecomment-982933214
This hasn't cause further issues because we haven't fully implemented compression for KRaft. Create https://issues.apache.org/jira/browse/KAFKA-13489 track this and add better tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11556: MINOR: Pass along compression type to snapshot writer
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11556:
URL: https://github.com/apache/kafka/pull/11556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio edited a comment on pull request #11556: MINOR: Pass along compression type to snapshot writer
Posted by GitBox <gi...@apache.org>.
jsancio edited a comment on pull request #11556:
URL: https://github.com/apache/kafka/pull/11556#issuecomment-982933214
This hasn't cause further issues because we haven't fully implemented compression for KRaft. Created https://issues.apache.org/jira/browse/KAFKA-13489 track this and add better tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org